Commit Graph

3 Commits

Author SHA1 Message Date
Elliot Lee
7438640753 CI: Build and test using .nvmrc node version (#101)
Use the node version specified in .nvmrc

We specify node version 10.22.0 so that CI will let us know if we break our minimum node version with any later changes, even if there are future updates to the 10.x release line.

In other words, this ensures that the minimum version in package.json is always tested by CI, as well as the latest 10.x version.

For example, if a new feature is added in 10.23 and we use it, we want CI to fail so that we know to update the minimum in
package.json.

Co-authored-by: Nathan Nichols <natenichols@cox.net>
2020-08-21 14:52:12 -07:00
Elliot Lee
e2cc829313 Set minimum node version to 10.22; specify v12 for nvm (#100)
- Using older versions of node can result in this error:

    TypeError: buf.writeBigUInt64BE is not a function

- nvm can automatically use the version specified in .nvmrc. Use node
  version 12 because it is currently recommended for most users
2020-08-21 13:21:33 -07:00
Elliot Lee
d3b29945ea Restrict to node version 10
Many unit tests fail under node 12. It is possible that some of these
are caused by issues in node that will be fixed in the future.

This also removes the dependency on 'assert-diff' since it is not
necessary. It can easily be re-added in the future, if needed.
2019-07-16 21:55:42 -07:00