Nathan Nichols
6c3099f9da
build: adjust for updates to @xrplf/eslint-config ( #1633 )
2021-09-23 21:04:07 -07:00
Mukul Jangid
bc1a6c97e4
test: write tests for sugar functions ( #1631 )
...
* test: write tests for sugar functions
2021-09-23 16:04:58 -04:00
Mayukha Vadari
87799b304b
ci: run lint tests ( #1603 )
...
* turn on lint tests
* remove tsc
* fix errors in src/utils/hashes
* fix linter errors in src/utils
* fix lint issues in test/
* resolve lint issues in src/client
* resolve dependency cycle
* resolve other linting issues in src/models
* resolve rest of linting issues
* fix tests
* fix linting errors in test/integration
* fix rest of linting issues
* fix test name
2021-09-22 16:39:10 -04:00
Mayukha Vadari
a92b611377
refactor: remove client.combine ( #1632 )
...
* remove combine
* remove tests
* fix tests
2021-09-21 15:16:34 -04:00
Nathan Nichols
b0d2fdbedb
Resolves TODOs in ./src/client ( #1617 )
...
* fix: fixes TODO's in ./src/client
2021-09-21 12:10:50 -07:00
Mayukha Vadari
b31968f367
refactor: move everything out of the common folder ( #1629 )
...
* remove common/constants (all in models now)
* remove common/txFlags (all in models now)
* move ecdsa from src/common to src
* move errors from src/common to src, export at top level
2021-09-21 14:25:37 -04:00
Jackson Mills
32b871c804
Remove old types ( #1630 )
...
* Remove transaction/types
* Delete common/types/commands
* Delete common/types
2021-09-21 09:08:56 -07:00
Jackson Mills
5b5f7484de
Remove sign.ts and move functionality into Wallet ( #1620 )
...
* Move sign.ts functionality into Wallet
* Move the corresponding tests to wallet's test cases and simplify them for readability
* Delete sign.ts
2021-09-17 12:16:57 -07:00
Mayukha Vadari
bd9b886799
refactor: move address-codec methods from client to utils ( #1627 )
2021-09-16 21:39:29 -04:00
Mayukha Vadari
fe71090546
refactor: remove unused methods/types in src/sugar ( #1625 )
...
* remove sugar/utils
* remove sugar/pathfind-types
* clean up src/sugar/index
2021-09-16 21:22:04 -04:00
Mayukha Vadari
17ab3537c3
fix: renames verify... methods to validate... ( #1624 )
...
* rename verify -> validate
* fix imports
* run eslint --fix on test/
2021-09-16 21:14:22 -04:00
Mayukha Vadari
3d98de6ffa
refactor: adds error response object ( #1619 )
...
* add error response object
* export error response properly
* type mockRippled
* fix linter
* fix ts
* fix comments
2021-09-16 16:44:44 -04:00
Nathan Nichols
d64dc368be
fix: remove the sugar/parse directory ( #1622 )
...
* fix: remove the sugar/parse directory
* feat: adds lsf flags
2021-09-16 10:13:39 -07:00
Mukul Jangid
fba2e0569f
refactor: Reimplement sugar functions and clean up ( #1559 )
...
* refactor: Reimplement sugar functions and clean up
2021-09-15 12:07:27 -04:00
Jackson Mills
f9cd2b45b5
Add Wallet.fromSecret(...) as an alias for Wallet.fromSeed(...) ( #1618 )
...
* Add alias to fromSeed for fromSecret
* Switch syntax to direct usage
2021-09-14 17:16:14 -04:00
Jackson Mills
7ac1b6aebc
Remove deprecated deriveAddress from Client ( #1614 )
...
* Removing deriveAddress and X from client
* Remove deriveAddress from derive.ts
* Remove linting exception for function lines
2021-09-14 17:14:34 -04:00
Jackson Mills
7a5a1afd25
Change multisign to return an encoded transaction ( #1615 )
2021-09-14 17:14:34 -04:00
Mayukha Vadari
a6e08f5481
Lints src/wallet and test/wallet ( #1600 )
...
* lint src/wallet/index
* lint generateFaucetWallet
* lint tests
* respond to comments
* change max-lines-per-function to 40
* remove * import
* fix TS issues
2021-09-14 17:14:34 -04:00
Mayukha Vadari
9d28540710
Lint integration test files and browser test files ( #1612 )
...
* clean up utils
* more cleanup
* remove client.sign
* remove unneeded tests
* remove unneeded infra
* move helper functions to separate files
* fix linter issues
* more cleanup
* make helper functions more generally useful
* fix test account funding
* add import note to README
* lint browser tests
* run eslint --fix
2021-09-14 17:14:34 -04:00
Nathan Nichols
c9adbc9981
build: update typescript version ( #1601 )
2021-09-14 17:14:32 -04:00
Mukul Jangid
09522e9ce2
refactor: add verify() function ( #1552 )
...
* refactor: add verify() function
2021-09-14 17:11:53 -04:00
Omar Khan
ed23739a8d
add submit transaction methods ( #1611 )
...
Adds submit transaction methods: submitTransaction and submitSignedTransaction.
2021-09-14 17:08:44 -04:00
Nathan Nichols
df1fd90f55
feat: cleanup flag naming ( #1609 )
...
* feat: cleanup flag naming
2021-09-14 17:08:44 -04:00
Nathan Nichols
bfb52b0d94
Lint utils directory ( #1563 )
...
* Lint the utils directory
* Modify computeLedgerHash to take new Ledger format.
2021-09-14 17:08:44 -04:00
Mayukha Vadari
a4fa1b4adb
Removes all prepare methods ( #1605 )
...
* deprecate and alias prepareTransaction
* delete prepareTransaction and replace methods in check-cancel
* WIP update check-cash
* remove all prepares
* remove prepares from client
* fix ts issues
* remove tests
* fix tests
* additional cleanup
* fix integration tests
* remove console statement
* re-add helper function
* fix imports
* fix more issues with integration tests
Co-authored-by: Omar Khan <khancodegt@gmail.com >
2021-09-14 17:08:44 -04:00
Jackson Mills
830525ef9c
Refactoring existing hash utils and adding tests ( #1557 )
...
Write toHash utils and tests, then fix naming to match our standards of camelCase
2021-09-14 17:08:44 -04:00
Jackson Mills
99f3b6b200
Signer fixes ( #1604 )
...
* Factor out reused wallet generation
* Remove extraneous types
* Clarify that multisign takes signed transactions
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2021-09-14 17:08:44 -04:00
Jackson Mills
c3774cd531
Signer ( #1573 )
...
Create Signer class to allow for offline signing, multisigning and signing authorizeChannel requests.
2021-09-14 17:08:44 -04:00
Omar Khan
db17bb1c57
implement Autofill Transaction ( #1574 )
...
Implements autofill() and setTransactionFlagsToNumber() to allow a Client to autofill fields in a Transaction.
2021-09-14 17:08:44 -04:00
Nathan Nichols
64cd604ee1
feat: Add typescript types to subscribe ( #1576 )
...
feat: Add typescript types to subscribe (#1576 )
2021-09-14 17:08:43 -04:00
Mayukha Vadari
2129239ac3
Lints src/common ( #1595 )
...
* lint errors (and remove unused error types)
* lint fee
* lint index
* lint ecdsa
* fix tests
* remove address tests from getFee
* fix more tests
* fix tests
* respond to comments
2021-09-14 17:08:43 -04:00
Nathan Nichols
2ca737391d
Adds @xrplf prettier config ( #1598 )
...
* build: new prettier config
2021-09-14 17:08:38 -04:00
Mayukha Vadari
685e4971b9
Lints src/client ( #1577 )
...
* lint backoff
* lint wsWrapper
* remove rangeset - not used
* split out connection.ts classes
* lint requestManager
* lint connectionManager
* lint most of connection
* fix most of client
* lint broadcastClient
* resolve more linter issues
* resolve magic numbers
* clean up more linting
* resolve rest of issues
* fix tests
* fix browser tests
* fix tests after rebase
* respond to comments
* fix dependency cycles
2021-09-14 17:06:20 -04:00
Mayukha Vadari
c9021ca144
Removes jsonschemas ( #1593 )
...
* remove jsonschemas stuff
* fix ts issues
* fix tests
* remove package
* remove scripts
* replace isValidAddress
2021-09-14 17:05:13 -04:00
Omar Khan
2d072a51ba
Refactor generateFaucetWallet to return a Wallet ( #1564 )
...
* add Wallet.generate() and
* return Wallet in generateFaucetWallet
* refactor Wallet tests
* rename wallet-generation.ts to generateFaucetWallet.ts
* rename and move Wallet.ts to src/wallet/index.ts and update webpack config
2021-09-14 17:05:13 -04:00
Mayukha Vadari
89e319fe0a
Lints src/models ( #1572 )
...
* resolve src/models/methods
* PaymentTransaction => Payment, remove empty returns
* fix common, method signatures
* fix checkCash
* handle complexity complaints
* fix jsdocs
* handle magic numbers
* finish models/transactions
* fix models/utils
* fix models/ledger
* fix ts issues
* fix tests
* fix modifiedoffercreatetransaction
* remove comments, fix additional TODO
2021-09-14 17:02:40 -04:00
Mayukha Vadari
1710d82232
test: removes the use of TestSuite ( #1566 )* switch all methods to new format* clean up rippleClient* rename files to remove ripple from name* additional cleanup
2021-09-14 17:02:39 -04:00
Omar Khan
b9b926e890
add getXAddress to Wallet ( #1558 )
...
- add getXAddress to Wallet
- refactor wallet tests
2021-09-14 17:02:39 -04:00
Mayukha Vadari
08e5b49b09
refactor: improves mock rippled structure ( #1569 )
...
* better error handling + tests
* fix tests
* change addResponse to take a string instead of a Request
* remove unneeded change
* respond to comments
* fix tests, re-lint
* improve error message
2021-09-14 17:02:39 -04:00
Nathan Nichols
6742e2048a
build: Initial linting setup ( #1560 )
...
* sets up linting config and runs `yarn lint --fix` once, so that all changes will show up correctly in future PRs.
* Note that there are still a lot of linter errors.
2021-09-14 17:00:46 -04:00
Mayukha Vadari
cfa014c44b
refactor: clean up Client and associated files ( #1556 )
...
* remove _PRIVATE
* make requestAll public
* un-type connection.request
* fix lodash imports
* add comments
* Rename files to camelCase
2021-09-14 16:56:39 -04:00
Jackson Mills
334a8adbf0
Remove deprecated functions from api.ts (aka client.ts) ( #1534 )
...
* Removed deprecated functions from client.ts
* Renamed files to be camelCase
* Created top-level utils folder and tied all sub-references to it
* Grouped tests for those utils into their own section
Co-authored-by: Nathan Nichols <natenichols@cox.net >
2021-09-14 16:56:37 -04:00
Mayukha Vadari
5be40d1090
fix: websocket wouldn't close properly on erroring test ( #1554 )
...
* fix: websocket wouldn't close properly on erroring test
* test: add test
2021-09-14 16:56:37 -04:00
Mayukha Vadari
221ebee87a
Remove ledger methods from Connection ( #1543 )
...
* remove ledger subscription from connection
* remove more client ledger stuff
* resolve TS concerns
* fix all tests except broadcast tests
* fix broadcast tests
* clean up more ledger stuff in testing
* respond to comments
2021-09-14 16:56:36 -04:00
Mayukha Vadari
7696fb957e
Removes methods that were just rippled wrappers ( #1550 )
...
* remove getAccountInfo
* remove getAccountObjects
* remove getBalanceSheet (gateway_balances)
* remove getLedger
* remove getOrders (account_orders)
* remove getPaymentChannel (ledger_entry)
* remove getTransaction(s) (tx/account_tx)
* remove getSettings (account_info)
* remove getServerInfo (server_info)
* fix integ tests
* remove submit (also deprecated)
* fix integ tests
* add TODO
2021-09-14 16:56:36 -04:00
Mayukha Vadari
e90257be2f
Edit Client constructor to take a server URI ( #1544 )
...
* edit Client
* fix TS issues + tests
* minor edits
* rename ClientBroadcast -> BroadcastClient
2021-09-14 16:56:36 -04:00
Mayukha Vadari
d1cfbf42e6
Rewrite XrplClient.request and general cleanup ( #1519 )
...
* first attempt at overloading
* fix TS issues
* improve connection typing
* more cleanup
* edit all ledger files
* more renames
* fix all other request calls
* clean up serverinfo
* fixes more request calls
* remove old legacy browser stuff
* remove unused types
* remove exports from objects
* add type to method signatures
* add ledger requests
* fix most tests
* comment out formatBidsAndAsks
* fix proxy test
* comment out failing tests
* move client-related files into client
* add payment channel requests
* fix imports
* remove finished TODOs
* fix tests
* fix integ tests
* remove exported types
* better ci
2021-09-14 16:56:36 -04:00
Mukul Jangid
1baccd6c57
refactor: define typescript type for SetRegularKey transaction ( #1548 )
...
* refactor: define typescript type for SetRegularKey transaction
2021-09-14 16:56:36 -04:00
Nathan Nichols
4842a06f8a
refactor: Define PaymentChannelFund transaction model ( #1535 )
...
refactor: Define PaymentChannelFund transaction model (#1535 )
2021-09-14 16:56:36 -04:00
Nathan Nichols
2509a2906a
refactor: Define EscrowCreate transaction model ( #1530 )
...
refactor: Define EscrowCreate transaction model (#1530 )
2021-09-14 16:56:36 -04:00