From f5e1a4a588e555db600afa0905ef827c75194ff6 Mon Sep 17 00:00:00 2001
From: Elliot Lee <github.public@intelliot.com>
Date: Fri, 10 Aug 2018 14:54:01 -0700
Subject: [PATCH] Revert "Expose validation methods in public api"

This reverts commit 9e9a0a7d9b676ee6bf548ab01c9dd3219b76f442.

We should move methods like deriveKeypair and deriveAddress
off of the schemaValidator object.
---
 src/api.ts                     | 5 ++---
 src/common/schema-validator.ts | 7 ++-----
 src/common/utils.ts            | 6 ++----
 test/api-test.js               | 2 +-
 test/broadcast-api-test.js     | 2 +-
 5 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/src/api.ts b/src/api.ts
index 4c39cc22..c2b0245c 100644
--- a/src/api.ts
+++ b/src/api.ts
@@ -109,7 +109,8 @@ class RippleAPI extends EventEmitter {
   static _PRIVATE = {
     validate,
     RangeSet,
-    ledgerUtils
+    ledgerUtils,
+    schemaValidator
   }
 
   constructor(options: APIOptions = {}) {
@@ -328,8 +329,6 @@ class RippleAPI extends EventEmitter {
   dropsToXrp = dropsToXrp
   iso8601ToRippleTime = iso8601ToRippleTime
   txFlags = txFlags
-
-  static schemaValidator = schemaValidator
 }
 
 export {
diff --git a/src/common/schema-validator.ts b/src/common/schema-validator.ts
index 393aa2d4..a0b10feb 100644
--- a/src/common/schema-validator.ts
+++ b/src/common/schema-validator.ts
@@ -3,7 +3,7 @@ import * as assert from 'assert'
 const {Validator} = require('jsonschema')
 import {ValidationError} from './errors'
 import {isValidAddress} from 'ripple-address-codec'
-import {isValidSecret,deriveKeypair,deriveAddress} from './utils'
+import {isValidSecret} from './utils'
 
 function loadSchemas() {
   // listed explicitly for webpack (instead of scanning schemas directory)
@@ -158,8 +158,5 @@ function schemaValidate(schemaName: string, object: any): void {
 
 export {
   schemaValidate,
-  isValidAddress,
-  isValidSecret,
-  deriveKeypair,
-  deriveAddress
+  isValidSecret
 }
diff --git a/src/common/utils.ts b/src/common/utils.ts
index 0716ad18..3781ec86 100644
--- a/src/common/utils.ts
+++ b/src/common/utils.ts
@@ -1,6 +1,6 @@
 import * as _ from 'lodash'
 import BigNumber from 'bignumber.js'
-import {deriveKeypair,deriveAddress} from 'ripple-keypairs'
+import {deriveKeypair} from 'ripple-keypairs'
 import {Amount, RippledAmount} from './types/objects'
 import {ValidationError} from './errors'
 
@@ -155,8 +155,6 @@ export {
   removeUndefined,
   rippleTimeToISO8601,
   iso8601ToRippleTime,
-  isValidSecret,
-  deriveKeypair,
-  deriveAddress
+  isValidSecret
 }
 
diff --git a/test/api-test.js b/test/api-test.js
index 47aa63be..6bd8ed0d 100644
--- a/test/api-test.js
+++ b/test/api-test.js
@@ -13,7 +13,7 @@ const hashes = require('./fixtures/hashes');
 const address = addresses.ACCOUNT;
 const utils = RippleAPI._PRIVATE.ledgerUtils;
 const ledgerClosed = require('./fixtures/rippled/ledger-close-newer');
-const schemaValidator = RippleAPI.schemaValidator;
+const schemaValidator = RippleAPI._PRIVATE.schemaValidator;
 const binary = require('ripple-binary-codec');
 const BigNumber = require('bignumber.js')
 assert.options.strict = true;
diff --git a/test/broadcast-api-test.js b/test/broadcast-api-test.js
index 9e8c2d20..1aff8908 100644
--- a/test/broadcast-api-test.js
+++ b/test/broadcast-api-test.js
@@ -6,7 +6,7 @@ const setupAPI = require('./setup-api');
 const responses = require('./fixtures').responses;
 const ledgerClosed = require('./fixtures/rippled/ledger-close');
 const RippleAPI = require('ripple-api').RippleAPI;
-const schemaValidator = RippleAPI.schemaValidator;
+const schemaValidator = RippleAPI._PRIVATE.schemaValidator;
 
 const TIMEOUT = process.browser ? 25000 : 10000;