From f4569ad84a7931c803e7568816a496326f91ded3 Mon Sep 17 00:00:00 2001 From: Arthur Britto Date: Mon, 8 Oct 2012 16:58:47 -0700 Subject: [PATCH] JS: improve hexToString and add unit tests. --- js/utils.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/js/utils.js b/js/utils.js index 511dacc4..a589ac39 100644 --- a/js/utils.js +++ b/js/utils.js @@ -128,11 +128,16 @@ var trace = function(comment, func) { }; var hexToString = function (h) { - var c = h.length % 1 ? "0" + h : h; var a = []; + var i = 0; - for (i=0; i != c.length; i += 2) { - a.push(String.fromCharCode(parseInt(c.substring(i, i+2), 16))); + if (h.length % 2) { + a.push(String.fromCharCode(parseInt(h.substring(0, 1), 16))); + i = 1; + } + + for (; i != h.length; i += 2) { + a.push(String.fromCharCode(parseInt(h.substring(i, i+2), 16))); } return a.join("");