Merge pull request #1098 from nickewansmith/fix-possible-unhandled-throw-on-send

Adds unit test for ripple#1092, fixes unhandled throw on upgraded ws send
This commit is contained in:
Elliot Lee
2020-01-05 19:51:58 -08:00
committed by GitHub
2 changed files with 35 additions and 7 deletions

View File

@@ -475,13 +475,17 @@ class Connection extends EventEmitter {
_send(message: string): Promise<void> {
this._trace('send', message)
return new Promise((resolve, reject) => {
this._ws.send(message, undefined, error => {
if (error) {
reject(new DisconnectedError(error.message, error))
} else {
resolve()
}
})
try {
this._ws.send(message, undefined, error => {
if (error) {
reject(new DisconnectedError(error.message, error))
} else {
resolve()
}
})
} catch (error) {
reject(new DisconnectedError(error.message, error))
}
})
}