From ef72c9fe02e635bd85afdcb90d25eab2667a4dad Mon Sep 17 00:00:00 2001
From: Chris Clark <clark@ripple.com>
Date: Mon, 16 Nov 2015 16:59:27 -0800
Subject: [PATCH] Fix TODOs in schemas

---
 src/common/constants.js                                      | 3 +--
 src/common/schemas/output/get-ledger.json                    | 2 +-
 src/common/schemas/output/get-settings.json                  | 4 ----
 .../schemas/specifications/suspended-payment-execution.json  | 4 ++--
 src/ledger/settings.js                                       | 1 -
 src/ledger/transaction-types.js                              | 1 -
 src/transaction/settings-types.js                            | 5 +----
 7 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/src/common/constants.js b/src/common/constants.js
index bd45ad5e..85b55032 100644
--- a/src/common/constants.js
+++ b/src/common/constants.js
@@ -39,8 +39,7 @@ const AccountFields = {
               length: 32, defaults: '0'},
   MessageKey: {name: 'messageKey'},
   Domain: {name: 'domain', encoding: 'hex'},
-  TransferRate: {name: 'transferRate', defaults: 0, shift: 9},
-  Signers: {name: 'signers'}
+  TransferRate: {name: 'transferRate', defaults: 0, shift: 9}
 };
 
 module.exports = {
diff --git a/src/common/schemas/output/get-ledger.json b/src/common/schemas/output/get-ledger.json
index 897317a2..ce029bca 100644
--- a/src/common/schemas/output/get-ledger.json
+++ b/src/common/schemas/output/get-ledger.json
@@ -20,7 +20,7 @@
     "closeFlags": {
       "type": "integer",
       "minimum": 0,
-      "description": "TODO"
+      "description": "A bit-map of flags relating to the closing of this ledger. Currently, the ledger has only one flag defined for `closeFlags`: **sLCF_NoConsensusTime** (value 1). If this flag is enabled, it means that validators were in conflict regarding the correct close time for the ledger, but built otherwise the same ledger, so they declared consensus while \"agreeing to disagree\" on the close time. In this case, the consensus ledger contains a `closeTime` value that is 1 second after that of the previous ledger. (In this case, there is no official close time, but the actual real-world close time is probably 3-6 seconds later than the specified `closeTime`.)"
     },
     "ledgerHash": {
       "$ref": "hash256",
diff --git a/src/common/schemas/output/get-settings.json b/src/common/schemas/output/get-settings.json
index efe027cc..c336bdb6 100644
--- a/src/common/schemas/output/get-settings.json
+++ b/src/common/schemas/output/get-settings.json
@@ -61,10 +61,6 @@
         {"type": "number", "minimum": 1, "maximum": 4.294967295}
       ]
     },
-    "signers": {
-      "type": "string",
-      "description": "TODO"
-    },
     "regularKey": {
       "oneOf": [
         {"$ref": "address"},
diff --git a/src/common/schemas/specifications/suspended-payment-execution.json b/src/common/schemas/specifications/suspended-payment-execution.json
index f5e78e84..c58cae42 100644
--- a/src/common/schemas/specifications/suspended-payment-execution.json
+++ b/src/common/schemas/specifications/suspended-payment-execution.json
@@ -21,11 +21,11 @@
     },
     "digest": {
       "$ref": "hash256",
-      "description": "TODO"
+      "description": "The original `digest` from the suspended payment creation transaction."
     },
     "proof": {
       "type": "string",
-      "description": "This value will be hashed to produce the digest."
+      "description": "A value that produces the digest when hashed."
     }
   },
   "required": ["owner", "suspensionSequence"],
diff --git a/src/ledger/settings.js b/src/ledger/settings.js
index bd0b3908..d257e1ad 100644
--- a/src/ledger/settings.js
+++ b/src/ledger/settings.js
@@ -24,7 +24,6 @@ type GetSettings = {
   messageKey?: string,
   domain?: string,
   transferRate?: ?number,
-  signers?: string,
   regularKey?: string
 }
 
diff --git a/src/ledger/transaction-types.js b/src/ledger/transaction-types.js
index 8920eb2a..09923a4a 100644
--- a/src/ledger/transaction-types.js
+++ b/src/ledger/transaction-types.js
@@ -48,7 +48,6 @@ type Settings = {
   messageKey?: string,
   domain?: string,
   transferRate?: number,
-  signers?: string,
   regularKey?: string
 }
 
diff --git a/src/transaction/settings-types.js b/src/transaction/settings-types.js
index ccc1e054..695dea2f 100644
--- a/src/transaction/settings-types.js
+++ b/src/transaction/settings-types.js
@@ -40,14 +40,11 @@ type SettingDomain = {
 type SettingTransferRate = {
   transferRate?: ?number,
 }
-type SettingSigners = {
-  signers?: string,
-}
 type SettingRegularKey = {
   regularKey?: string
 }
 
-export type Settings = SettingRegularKey | SettingSigners |
+export type Settings = SettingRegularKey |
   SettingTransferRate | SettingDomain | SettingMessageKey |
   SettingEmailHash | SettingDefaultRipple |
   SettingGlobalFreeze | SettingNoFreeze | SettingEnableTransactionIDTracking |