Signer fixes (#1604)

* Factor out reused wallet generation
* Remove extraneous types
* Clarify that multisign takes signed transactions

Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
This commit is contained in:
Jackson Mills
2021-09-09 09:34:25 -07:00
committed by Mayukha Vadari
parent c401f703c7
commit eb56eb181a
2 changed files with 20 additions and 34 deletions

View File

@@ -32,10 +32,10 @@ function sign(wallet: Wallet, tx: Transaction, forMultisign = false): string {
}
/**
* Takes several transactions (in object or blob form) and creates a single transaction with all Signers
* that then gets signed and returned.
* Takes several transactions with Signer fields (in object or blob form) and creates a
* single transaction with all Signers that then gets signed and returned.
*
* @param transactions - An array of Transactions (in object or blob form) to combine and sign.
* @param transactions - An array of signed Transactions (in object or blob form) to combine into a single signed Transaction.
* @returns A single signed Transaction which has all Signers from transactions within it.
* @throws ValidationError if:
* - There were no transactions given to sign