fix: add void return type to Promises (#1477)

Follow-up to #1476
This commit is contained in:
Elliot Lee
2021-07-26 12:04:46 -07:00
committed by GitHub
parent a973266434
commit dd30e33e8e
2 changed files with 4 additions and 4 deletions

View File

@@ -15,7 +15,7 @@ function setup(this: any, port_ = port) {
}) })
}) })
.then((got) => { .then((got) => {
return new Promise((resolve, reject) => { return new Promise<void>((resolve, reject) => {
this.api = new RippleAPI({server: baseUrl + got.port}) this.api = new RippleAPI({server: baseUrl + got.port})
this.api this.api
.connect() .connect()
@@ -37,7 +37,7 @@ function setup(this: any, port_ = port) {
function setupBroadcast(this: any) { function setupBroadcast(this: any) {
const servers = [port, port + 1].map((port_) => baseUrl + port_) const servers = [port, port + 1].map((port_) => baseUrl + port_)
this.api = new RippleAPIBroadcast(servers) this.api = new RippleAPIBroadcast(servers)
return new Promise((resolve, reject) => { return new Promise<void>((resolve, reject) => {
this.api this.api
.connect() .connect()
.then(() => { .then(() => {

View File

@@ -4,7 +4,7 @@ import {createMockRippled} from './mock-rippled'
import {getFreePort} from './utils' import {getFreePort} from './utils'
function setupMockRippledConnection(testcase, port) { function setupMockRippledConnection(testcase, port) {
return new Promise((resolve, reject) => { return new Promise<void>((resolve, reject) => {
testcase.mockRippled = createMockRippled(port) testcase.mockRippled = createMockRippled(port)
testcase._mockedServerPort = port testcase._mockedServerPort = port
testcase.api = new RippleAPI({server: 'ws://localhost:' + port}) testcase.api = new RippleAPI({server: 'ws://localhost:' + port})
@@ -22,7 +22,7 @@ function setupMockRippledConnection(testcase, port) {
} }
function setupMockRippledConnectionForBroadcast(testcase, ports) { function setupMockRippledConnectionForBroadcast(testcase, ports) {
return new Promise((resolve, reject) => { return new Promise<void>((resolve, reject) => {
const servers = ports.map((port) => 'ws://localhost:' + port) const servers = ports.map((port) => 'ws://localhost:' + port)
testcase.mocks = ports.map((port) => createMockRippled(port)) testcase.mocks = ports.map((port) => createMockRippled(port))
testcase.api = new RippleAPIBroadcast(servers) testcase.api = new RippleAPIBroadcast(servers)