From dc784d4567cad23ea54639a107e11b4156a2fd98 Mon Sep 17 00:00:00 2001 From: Chris Clark Date: Mon, 21 Mar 2016 15:29:52 -0700 Subject: [PATCH] Fix makerExchangeRate for getOrders when rippled provides quality --- src/ledger/parse/account-order.js | 9 ++++++--- test/fixtures/rippled/account-offers.js | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/ledger/parse/account-order.js b/src/ledger/parse/account-order.js index 517fdeb5..322ba6b7 100644 --- a/src/ledger/parse/account-order.js +++ b/src/ledger/parse/account-order.js @@ -1,5 +1,5 @@ /* @flow */ -'use strict'; +'use strict'; // eslint-disable-line strict const utils = require('./utils'); const flags = require('./flags').orderFlags; const parseAmount = require('./amount'); @@ -31,11 +31,14 @@ function parseAccountOrder(address: string, order: Object): Object { expirationTime: utils.parseTimestamp(order.expiration) }); + const makerExchangeRate = order.quality ? + utils.adjustQualityForXRP(order.quality.toString(), + takerGetsAmount.currency, takerPaysAmount.currency) : + computeQuality(takerGetsAmount, takerPaysAmount); const properties = { maker: address, sequence: order.seq, - makerExchangeRate: order.quality ? order.quality.toString() - : computeQuality(takerGetsAmount, takerPaysAmount) + makerExchangeRate: makerExchangeRate }; return {specification, properties}; diff --git a/test/fixtures/rippled/account-offers.js b/test/fixtures/rippled/account-offers.js index 551e12d1..f511cc98 100644 --- a/test/fixtures/rippled/account-offers.js +++ b/test/fixtures/rippled/account-offers.js @@ -1,4 +1,4 @@ -'use strict'; +'use strict'; // eslint-disable-line strict const _ = require('lodash'); const addresses = require('../addresses'); @@ -160,6 +160,7 @@ module.exports = function(request, options = {}) { { 'flags': 0, 'seq': 814018, + 'quality': '16922629533.64839', 'taker_gets': { 'currency': 'NZD', 'issuer': 'rsP3mgGb2tcYUrxiLFiHJiQXhsziegtwBc',