mirror of
https://github.com/Xahau/xahau.js.git
synced 2025-11-21 04:35:49 +00:00
[FIX] transaction without explicit remote
remote was instantiated as an object and checks through the class for `this.remote` would pass and cause unintended behavior e.g. `.complete()` would view an undefined remote as untrusted and not allow local signing e.g. calling `_computeFee()` with an undefined remote would crash ripple-lib
This commit is contained in:
@@ -60,7 +60,7 @@ function Transaction(remote) {
|
||||
|
||||
var self = this;
|
||||
|
||||
var remote = remote || { };
|
||||
var remote = remote || void(0);
|
||||
|
||||
this.remote = remote;
|
||||
|
||||
@@ -69,7 +69,7 @@ function Transaction(remote) {
|
||||
|
||||
this._secret = void(0);
|
||||
this._build_path = false;
|
||||
this._maxFee = this.remote.max_fee;
|
||||
this._maxFee = (typeof remote === 'object') ? this.remote.max_fee : void(0);
|
||||
|
||||
this.state = 'unsubmitted';
|
||||
this.finalized = false;
|
||||
@@ -241,7 +241,7 @@ Transaction.prototype.finalize = function(message) {
|
||||
};
|
||||
|
||||
Transaction.prototype._accountSecret = function(account) {
|
||||
return this.remote.secrets[account];
|
||||
return this.remote ? this.remote.secrets[account] : void(0);
|
||||
};
|
||||
|
||||
/**
|
||||
@@ -266,6 +266,10 @@ Transaction.prototype.feeUnits = function() {
|
||||
*/
|
||||
|
||||
Transaction.prototype._computeFee = function() {
|
||||
if (!this.remote) {
|
||||
return void(0);
|
||||
}
|
||||
|
||||
var servers = this.remote._servers;
|
||||
var fees = [ ];
|
||||
|
||||
@@ -898,6 +902,10 @@ Transaction.prototype.submit = function(callback) {
|
||||
|
||||
var account = this.tx_json.Account;
|
||||
|
||||
if (!this.remote) {
|
||||
return this.emit('error', new Error('No remote found'));
|
||||
}
|
||||
|
||||
if (!UInt160.is_valid(account)) {
|
||||
return this.emit('error', new RippleError('tejInvalidAccount', 'Account is missing or invalid'));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user