[FIX] support string '0' being interpreted as XRP

This commit is contained in:
Geert Weening
2014-11-11 11:51:12 -08:00
parent 261b72d0fc
commit bdbf264771
2 changed files with 11 additions and 1 deletions

View File

@@ -68,7 +68,7 @@ Currency.prototype.parse_json = function(j, shouldInterpretXrpAsIou) {
case 'string':
// if an empty string is given, fall back to XRP
if (!j) {
if (!j || j === '0') {
this.parse_hex(shouldInterpretXrpAsIou ? Currency.HEX_CURRENCY_BAD : Currency.HEX_ZERO);
break;
}

View File

@@ -198,6 +198,16 @@ describe('Currency', function() {
cur2 = currency.from_json(cur);
assert.strictEqual(cur.to_json(), cur2.to_json());
});
it('should parse json 0', function() {
var cur = currency.from_json(0);
assert.strictEqual(cur.to_json(), 'XRP');
assert.strictEqual(cur.get_iso(), 'XRP');
});
it('should parse json 0', function() {
var cur = currency.from_json('0');
assert.strictEqual(cur.to_json(), 'XRP');
assert.strictEqual(cur.get_iso(), 'XRP');
});
});
describe('is_valid', function() {