refactor: improves mock rippled structure (#1569)

* better error handling + tests

* fix tests

* change addResponse to take a string instead of a Request

* remove unneeded change

* respond to comments

* fix tests, re-lint

* improve error message
This commit is contained in:
Mayukha Vadari
2021-08-27 10:17:39 -04:00
parent 759e075e54
commit b8be6c2f1b
30 changed files with 763 additions and 2110 deletions

View File

@@ -10,30 +10,18 @@ import { assertResultMatch, TestSuite } from "../testUtils";
*/
export default <TestSuite>{
async getBalances(client, address, mockRippled) {
mockRippled.addResponse(
{ command: "account_info" },
rippled.account_info.normal
);
mockRippled.addResponse(
{ command: "account_lines" },
rippledAccountLines.normal
);
mockRippled.addResponse({ command: "ledger" }, rippled.ledger.normal);
mockRippled.addResponse("account_info", rippled.account_info.normal);
mockRippled.addResponse("account_lines", rippledAccountLines.normal);
mockRippled.addResponse("ledger", rippled.ledger.normal);
const result = await client.getBalances(address);
assertResultMatch(result, responses.getBalances, "getBalances");
},
"getBalances - limit": async (client, address, mockRippled) => {
const options = { limit: 3, ledgerVersion: 123456 };
mockRippled.addResponse(
{ command: "account_info" },
rippled.account_info.normal
);
mockRippled.addResponse(
{ command: "account_lines" },
rippledAccountLines.normal
);
mockRippled.addResponse({ command: "ledger" }, rippled.ledger.normal);
mockRippled.addResponse("account_info", rippled.account_info.normal);
mockRippled.addResponse("account_lines", rippledAccountLines.normal);
mockRippled.addResponse("ledger", rippled.ledger.normal);
const expectedResponse = responses.getBalances.slice(0, 3);
const result = await client.getBalances(address, options);
assertResultMatch(result, expectedResponse, "getBalances");
@@ -41,15 +29,9 @@ export default <TestSuite>{
"getBalances - limit & currency": async (client, address, mockRippled) => {
const options = { currency: "USD", limit: 3 };
mockRippled.addResponse(
{ command: "account_info" },
rippled.account_info.normal
);
mockRippled.addResponse(
{ command: "account_lines" },
rippledAccountLines.normal
);
mockRippled.addResponse({ command: "ledger" }, rippled.ledger.normal);
mockRippled.addResponse("account_info", rippled.account_info.normal);
mockRippled.addResponse("account_lines", rippledAccountLines.normal);
mockRippled.addResponse("ledger", rippled.ledger.normal);
const expectedResponse = responses.getBalances
.filter((item) => item.currency === "USD")
.slice(0, 3);
@@ -67,15 +49,9 @@ export default <TestSuite>{
counterparty: "rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B",
limit: 3,
};
mockRippled.addResponse(
{ command: "account_info" },
rippled.account_info.normal
);
mockRippled.addResponse(
{ command: "account_lines" },
rippledAccountLines.normal
);
mockRippled.addResponse({ command: "ledger" }, rippled.ledger.normal);
mockRippled.addResponse("account_info", rippled.account_info.normal);
mockRippled.addResponse("account_lines", rippledAccountLines.normal);
mockRippled.addResponse("ledger", rippled.ledger.normal);
const expectedResponse = responses.getBalances
.filter(