From b7de3b0ea96d75721fa46accad6ba9eb56148bb5 Mon Sep 17 00:00:00 2001 From: Elliot Lee Date: Mon, 26 Jul 2021 16:12:15 -0700 Subject: [PATCH] feat: minor improvement to docs (#1251) --- docs/index.md | 4 ++-- docs/src/prepareTransaction.md.ejs | 4 ++-- src/transaction/utils.ts | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/index.md b/docs/index.md index 570a8430..05e66039 100644 --- a/docs/index.md +++ b/docs/index.md @@ -4677,8 +4677,8 @@ Notably, this is the preferred method for preparing `DepositPreauth` or `Account Name | Type | Description ---- | ---- | ----------- -transaction | [transaction](https://developers.ripple.com/transaction-formats.html) | The specification (JSON) of the transaction to prepare. Set `Account` to the address of the account that is creating the transaction. You may omit auto-fillable fields like `Fee`, `Flags`, and `Sequence` to have them set automatically. -instructions | [instructions](#transaction-instructions) | *Optional* Instructions for executing the transaction. +transaction | [Transaction](https://xrpl.org/transaction-formats.html) | The specification (JSON) of the transaction to prepare. Set `Account` to the address of the account that is creating the transaction. You may omit auto-fillable fields like `Fee`, `Flags`, and `Sequence` to have them set automatically. +instructions | [Instructions](#transaction-instructions) | *Optional* Instructions for executing the transaction. ### Return Value diff --git a/docs/src/prepareTransaction.md.ejs b/docs/src/prepareTransaction.md.ejs index 48f4bdd9..7cd5345a 100644 --- a/docs/src/prepareTransaction.md.ejs +++ b/docs/src/prepareTransaction.md.ejs @@ -12,8 +12,8 @@ Notably, this is the preferred method for preparing `DepositPreauth` or `Account Name | Type | Description ---- | ---- | ----------- -transaction | [transaction](https://developers.ripple.com/transaction-formats.html) | The specification (JSON) of the transaction to prepare. Set `Account` to the address of the account that is creating the transaction. You may omit auto-fillable fields like `Fee`, `Flags`, and `Sequence` to have them set automatically. -instructions | [instructions](#transaction-instructions) | *Optional* Instructions for executing the transaction. +transaction | [Transaction](https://xrpl.org/transaction-formats.html) | The specification (JSON) of the transaction to prepare. Set `Account` to the address of the account that is creating the transaction. You may omit auto-fillable fields like `Fee`, `Flags`, and `Sequence` to have them set automatically. +instructions | [Instructions](#transaction-instructions) | *Optional* Instructions for executing the transaction. ### Return Value diff --git a/src/transaction/utils.ts b/src/transaction/utils.ts index b25e8db9..57edcd4a 100644 --- a/src/transaction/utils.ts +++ b/src/transaction/utils.ts @@ -293,6 +293,7 @@ function prepareTransaction( const cushion = api._feeCushion return api.getFee(cushion).then((fee) => { return api.connection.getFeeRef().then((feeRef) => { + // feeRef is the reference transaction cost in "fee units" const extraFee = newTxJSON.TransactionType !== 'EscrowFinish' || newTxJSON.Fulfillment === undefined