From 9f8502d522902812c210333c54feb2d5e5fd5842 Mon Sep 17 00:00:00 2001
From: Caleb Kniffen <ckniffen@ripple.com>
Date: Tue, 18 Jul 2023 13:38:53 -0500
Subject: [PATCH] feat: bump typescript to 5.x (#2387)

---
 package-lock.json                           | 16 ++++++++--------
 package.json                                |  2 +-
 packages/ripple-address-codec/src/index.ts  |  2 +-
 packages/ripple-address-codec/tsconfig.json |  1 -
 packages/ripple-binary-codec/tsconfig.json  |  1 -
 packages/xrpl/test/createMockRippled.ts     |  2 +-
 packages/xrpl/tsconfig.json                 |  1 -
 7 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 17d96b64..b9b5ccec 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -58,7 +58,7 @@
         "ts-jest": "^29.0.3",
         "ts-loader": "^9.2.5",
         "ts-node": "^10.2.1",
-        "typescript": "^4.4.2",
+        "typescript": "^5.1.6",
         "url": "^0.11.0",
         "webpack": "^5.81.0",
         "webpack-bundle-analyzer": "^4.1.0",
@@ -15527,16 +15527,16 @@
       "integrity": "sha512-7uc1O8h1M1g0rArakJdf0uLRSSgFcYexrVoKo+bzJd32gd4gDy2L/Z+8/FjPnU9ydY3pEnVPtr9FyscYY60K1g=="
     },
     "node_modules/typescript": {
-      "version": "4.9.5",
-      "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.9.5.tgz",
-      "integrity": "sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==",
+      "version": "5.1.6",
+      "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.1.6.tgz",
+      "integrity": "sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==",
       "dev": true,
       "bin": {
         "tsc": "bin/tsc",
         "tsserver": "bin/tsserver"
       },
       "engines": {
-        "node": ">=4.2.0"
+        "node": ">=14.17"
       }
     },
     "node_modules/ua-parser-js": {
@@ -28796,9 +28796,9 @@
       "integrity": "sha512-7uc1O8h1M1g0rArakJdf0uLRSSgFcYexrVoKo+bzJd32gd4gDy2L/Z+8/FjPnU9ydY3pEnVPtr9FyscYY60K1g=="
     },
     "typescript": {
-      "version": "4.9.5",
-      "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.9.5.tgz",
-      "integrity": "sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==",
+      "version": "5.1.6",
+      "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.1.6.tgz",
+      "integrity": "sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==",
       "dev": true
     },
     "ua-parser-js": {
diff --git a/package.json b/package.json
index b6fe5184..bb4ac201 100644
--- a/package.json
+++ b/package.json
@@ -62,7 +62,7 @@
     "ts-jest": "^29.0.3",
     "ts-loader": "^9.2.5",
     "ts-node": "^10.2.1",
-    "typescript": "^4.4.2",
+    "typescript": "^5.1.6",
     "url": "^0.11.0",
     "webpack": "^5.81.0",
     "webpack-bundle-analyzer": "^4.1.0",
diff --git a/packages/ripple-address-codec/src/index.ts b/packages/ripple-address-codec/src/index.ts
index 51053e88..2dced141 100644
--- a/packages/ripple-address-codec/src/index.ts
+++ b/packages/ripple-address-codec/src/index.ts
@@ -40,7 +40,7 @@ function encodeXAddress(
     // RIPEMD160 is 160 bits = 20 bytes
     throw new Error('Account ID must be 20 bytes')
   }
-  if (tag > MAX_32_BIT_UNSIGNED_INT) {
+  if (tag !== false && tag > MAX_32_BIT_UNSIGNED_INT) {
     throw new Error('Invalid tag')
   }
   const theTag = tag || 0
diff --git a/packages/ripple-address-codec/tsconfig.json b/packages/ripple-address-codec/tsconfig.json
index cc5a324a..941f61aa 100644
--- a/packages/ripple-address-codec/tsconfig.json
+++ b/packages/ripple-address-codec/tsconfig.json
@@ -11,7 +11,6 @@
     "noUnusedParameters": true,
     "removeComments": false,
     "preserveConstEnums": false,
-    "suppressImplicitAnyIndexErrors": false,
     "skipLibCheck": true,
     "declaration": true,
     "strictNullChecks": true
diff --git a/packages/ripple-binary-codec/tsconfig.json b/packages/ripple-binary-codec/tsconfig.json
index 9c8f38ba..645c4aea 100644
--- a/packages/ripple-binary-codec/tsconfig.json
+++ b/packages/ripple-binary-codec/tsconfig.json
@@ -14,7 +14,6 @@
     "noImplicitAny": false,
     "removeComments": false,
     "preserveConstEnums": false,
-    "suppressImplicitAnyIndexErrors": true,
     "skipLibCheck": true,
     "declaration": true
   },
diff --git a/packages/xrpl/test/createMockRippled.ts b/packages/xrpl/test/createMockRippled.ts
index bae75b6b..48ef5253 100644
--- a/packages/xrpl/test/createMockRippled.ts
+++ b/packages/xrpl/test/createMockRippled.ts
@@ -55,7 +55,7 @@ export type MockedWebSocketServer = WebSocketServer &
     addResponse: (
       command: string,
       response:
-        | Response
+        | BaseResponse
         | ErrorResponse
         | ((r: Request) => Response | ErrorResponse | Record<string, unknown>)
         | Record<string, unknown>,
diff --git a/packages/xrpl/tsconfig.json b/packages/xrpl/tsconfig.json
index 9a2f13b9..a906155d 100644
--- a/packages/xrpl/tsconfig.json
+++ b/packages/xrpl/tsconfig.json
@@ -12,7 +12,6 @@
     "removeComments": true,
     "preserveConstEnums": false,
     "esModuleInterop": true,
-    "suppressImplicitAnyIndexErrors": false,
     "resolveJsonModule": true,
     "preserveSymlinks": true
   },