From 8ed5f764fab59855d913ea356a6665dc406345e7 Mon Sep 17 00:00:00 2001
From: wilsonianb <bwilson@ripple.com>
Date: Mon, 6 Nov 2017 13:49:38 -0600
Subject: [PATCH] Add missing condition or fulfillment test

---
 test/api-test.js                                   | 14 ++++++++++++++
 test/fixtures/requests/index.js                    |  4 +++-
 .../prepare-escrow-execution-no-condition.json     |  5 +++++
 .../prepare-escrow-execution-no-fulfillment.json   |  5 +++++
 4 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 test/fixtures/requests/prepare-escrow-execution-no-condition.json
 create mode 100644 test/fixtures/requests/prepare-escrow-execution-no-fulfillment.json

diff --git a/test/api-test.js b/test/api-test.js
index 1a35f997..c8292728 100644
--- a/test/api-test.js
+++ b/test/api-test.js
@@ -302,6 +302,20 @@ describe('RippleAPI', function() {
           'prepare'));
   });
 
+  it('prepareEscrowExecution - no condition', function() {
+    assert.throws(() => {
+      this.api.prepareEscrowExecution(address,
+      requests.prepareEscrowExecution.noCondition, instructions);
+    }, /"condition" and "fulfillment" fields on EscrowFinish must only be specified together./);
+  });
+
+  it('prepareEscrowExecution - no fulfillment', function() {
+    assert.throws(() => {
+      this.api.prepareEscrowExecution(address,
+      requests.prepareEscrowExecution.noFulfillment, instructions);
+    }, /"condition" and "fulfillment" fields on EscrowFinish must only be specified together./);
+  });
+
   it('prepareEscrowCancellation', function() {
     return this.api.prepareEscrowCancellation(
       address,
diff --git a/test/fixtures/requests/index.js b/test/fixtures/requests/index.js
index ab5b67a6..2e337711 100644
--- a/test/fixtures/requests/index.js
+++ b/test/fixtures/requests/index.js
@@ -30,7 +30,9 @@ module.exports = {
   },
   prepareEscrowExecution: {
     normal: require('./prepare-escrow-execution'),
-    simple: require('./prepare-escrow-execution-simple')
+    simple: require('./prepare-escrow-execution-simple'),
+    noCondition: require('./prepare-escrow-execution-no-condition'),
+    noFulfillment: require('./prepare-escrow-execution-no-fulfillment')
   },
   prepareEscrowCancellation: {
     normal: require('./prepare-escrow-cancellation'),
diff --git a/test/fixtures/requests/prepare-escrow-execution-no-condition.json b/test/fixtures/requests/prepare-escrow-execution-no-condition.json
new file mode 100644
index 00000000..b7408299
--- /dev/null
+++ b/test/fixtures/requests/prepare-escrow-execution-no-condition.json
@@ -0,0 +1,5 @@
+{
+  "owner": "r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59",
+  "escrowSequence": 1234,
+  "fulfillment": "A0028000"
+}
diff --git a/test/fixtures/requests/prepare-escrow-execution-no-fulfillment.json b/test/fixtures/requests/prepare-escrow-execution-no-fulfillment.json
new file mode 100644
index 00000000..603bedb9
--- /dev/null
+++ b/test/fixtures/requests/prepare-escrow-execution-no-fulfillment.json
@@ -0,0 +1,5 @@
+{
+  "owner": "r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59",
+  "escrowSequence": 1234,
+  "condition": "A0258020E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855810100"
+}