From 86d485869a4e8a8d5b60afca265e497d57c684be Mon Sep 17 00:00:00 2001 From: Elliot Lee Date: Tue, 3 Sep 2019 11:03:54 -0700 Subject: [PATCH] Use Buffer.from() --- packages/ripple-address-codec/package.json | 2 +- packages/ripple-address-codec/src/utils.ts | 2 +- packages/ripple-address-codec/test/codec-test.js | 4 ++-- packages/ripple-address-codec/test/xrp-codec-test.js | 4 ++-- packages/ripple-address-codec/tsconfig.json | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/ripple-address-codec/package.json b/packages/ripple-address-codec/package.json index 66210037..a754a0fa 100644 --- a/packages/ripple-address-codec/package.json +++ b/packages/ripple-address-codec/package.json @@ -14,7 +14,7 @@ }, "scripts": { "compile": "tsc", - "test": "tsc && mocha", + "test": "tsc && tslint -p ./ && mocha", "lint": "tslint -p ./" }, "devDependencies": { diff --git a/packages/ripple-address-codec/src/utils.ts b/packages/ripple-address-codec/src/utils.ts index 671828a7..db654df4 100644 --- a/packages/ripple-address-codec/src/utils.ts +++ b/packages/ripple-address-codec/src/utils.ts @@ -22,7 +22,7 @@ function isSequence(val) { * a single element or a sequence, which has a `length` property and supports * element retrieval via sequence[ix]. * -* > concatArgs(1, [2, 3], new Buffer([4,5]), new Uint8Array([6, 7])); +* > concatArgs(1, [2, 3], Buffer.from([4,5]), new Uint8Array([6, 7])); * [1,2,3,4,5,6,7] * * @return {Array} - concatenated arguments diff --git a/packages/ripple-address-codec/test/codec-test.js b/packages/ripple-address-codec/test/codec-test.js index df47592a..3e93584e 100644 --- a/packages/ripple-address-codec/test/codec-test.js +++ b/packages/ripple-address-codec/test/codec-test.js @@ -2,11 +2,11 @@ const assert = require('assert') const api = require('../dist') function toHex(bytes) { - return new Buffer(bytes).toString('hex').toUpperCase() + return Buffer.from(bytes).toString('hex').toUpperCase() } function toBytes(hex) { - return new Buffer(hex, 'hex').toJSON().data + return Buffer.from(hex, 'hex').toJSON().data } describe('ripple-address-codec', function() { diff --git a/packages/ripple-address-codec/test/xrp-codec-test.js b/packages/ripple-address-codec/test/xrp-codec-test.js index 5ba178fa..78709f37 100644 --- a/packages/ripple-address-codec/test/xrp-codec-test.js +++ b/packages/ripple-address-codec/test/xrp-codec-test.js @@ -2,11 +2,11 @@ const assert = require('assert') const api = require('../dist/xrp-codec') function toHex(bytes) { - return new Buffer(bytes).toString('hex').toUpperCase() + return Buffer.from(bytes).toString('hex').toUpperCase() } function toBytes(hex) { - return new Buffer(hex, 'hex').toJSON().data + return Buffer.from(hex, 'hex').toJSON().data } describe('ripple-address-codec', function() { diff --git a/packages/ripple-address-codec/tsconfig.json b/packages/ripple-address-codec/tsconfig.json index 8c617d31..fe11a8f4 100644 --- a/packages/ripple-address-codec/tsconfig.json +++ b/packages/ripple-address-codec/tsconfig.json @@ -17,7 +17,7 @@ "suppressImplicitAnyIndexErrors": false, "sourceMap": true, "skipLibCheck": true, - "allowJs": true + "declaration": true }, "include": [ "src/**/*.ts"