CI: Build and test using .nvmrc node version (#101)

Use the node version specified in .nvmrc

We specify node version 10.22.0 so that CI will let us know if we break our minimum node version with any later changes, even if there are future updates to the 10.x release line.

In other words, this ensures that the minimum version in package.json is always tested by CI, as well as the latest 10.x version.

For example, if a new feature is added in 10.23 and we use it, we want CI to fail so that we know to update the minimum in
package.json.

Co-authored-by: Nathan Nichols <natenichols@cox.net>
This commit is contained in:
Elliot Lee
2020-08-21 14:52:12 -07:00
parent e2cc829313
commit 7438640753
3 changed files with 20 additions and 2 deletions

View File

@@ -10,6 +10,24 @@ on:
branches: [ master ]
jobs:
build_with_nvm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Read .nvmrc # From https://github.com/actions/setup-node/issues/32#issuecomment-525791142
run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"
id: nvm
- name: Use Node.js (.nvmrc)
uses: actions/setup-node@v1
with:
node-version: "${{ steps.nvm.outputs.NVMRC }}"
- run: yarn install
- run: yarn run test
- run: yarn run lint
- run: yarn run compile
build:
runs-on: ubuntu-latest

View File

@@ -1 +1 @@
12
10.22.0

View File

@@ -51,7 +51,7 @@
"semi": true
},
"engines": {
"node": ">=10.22",
"node": ">=10.22.0",
"yarn": "^1.22.4"
}
}