Lint

src/log.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var assert = require('assert');
+const assert = require('assert');
 
 /**
  * Logging functionality for ripple-lib and any applications built on it.
@@ -36,13 +36,13 @@ function Log(namespace) {
  * @return {Log} sub logger
  */
 Log.prototype.sub = function(namespace) {
-  var subNamespace = this._namespace.slice();
+  const subNamespace = this._namespace.slice();
 
   if (namespace && typeof namespace === 'string') {
     subNamespace.push(namespace);
   }
 
-  var subLogger = new Log(subNamespace);
+  const subLogger = new Log(subNamespace);
   subLogger._setParent(this);
   return subLogger;
 };
@@ -53,7 +53,7 @@ Log.prototype._setParent = function(parentLogger) {
 
 Log.makeLevel = function(level) {
   return function() {
-    var args = Array.prototype.slice.apply(arguments);
+    const args = Array.prototype.slice.apply(arguments);
     args[0] = this._prefix + args[0];
     Log.engine.logObject.apply(Log, [level].concat(args[0], [args.slice(2)]));
   };
@@ -71,7 +71,7 @@ Log.prototype.error = Log.makeLevel(4);
  */
 
 function getLogInfo(message, args) {
-  var stack = new Error().stack;
+  const stack = new Error().stack;
 
   return [
     // Timestamp
@@ -104,7 +104,7 @@ function logMessage(logLevel, args) {
   }
 }
 
-var engines = {};
+const engines = {};
 
 /**
  * Basic logging connector.
@@ -113,8 +113,8 @@ var engines = {};
  * implementations. This is the logging engine used in Node.js.
  */
 engines.basic = {
-  logObject: function logObject(level, message, args) {
+  logObject: function logObject(level, message, args_) {
-    args = args.map(function(arg) {
+    const args = args_.map(function(arg) {
       return JSON.stringify(arg, null, 2);
     });
 
@@ -130,8 +130,8 @@ engines.basic = {
  * function without any stringification.
  */
 engines.interactive = {
-  logObject: function(level, message, args) {
+  logObject: function(level, message, args_) {
-    args = args.map(function(arg) {
+    const args = args_.map(function(arg) {
       return /MSIE/.test(navigator.userAgent)
       ? JSON.stringify(arg, null, 2)
       : arg;

src/server.js

@@ -5,6 +5,7 @@ const util = require('util');
 const url = require('url');
 const LRU = require('lru-cache');
 const EventEmitter = require('events').EventEmitter;
+const RippleError = require('./').RippleError;
 const Amount = require('./amount').Amount;
 const RangeSet = require('./rangeset').RangeSet;
 const log = require('./log').internal.sub('server');
@@ -442,12 +443,12 @@ Server.prototype.connect = function() {
   self.emit('connecting');
 
   ws.onmessage = function onMessage(msg) {
-    var message = msg.data;
+    let message = msg.data;
 
     try {
       message = JSON.parse(message);
     } catch (e) {
-      var error = new RippleError('unexpected',
+      const error = new RippleError('unexpected',
         'Unexpected response from server: ' + JSON.stringify(message));
 
       self.emit('unexpected', message);

test/remote-test.js

@@ -2,29 +2,29 @@
 
 'use strict';
 
-var assert = require('assert');
+const assert = require('assert-diff');
-var Remote = require('ripple-lib').Remote;
+const Remote = require('ripple-lib').Remote;
-var Server = require('ripple-lib').Server;
+const Server = require('ripple-lib').Server;
-var Transaction = require('ripple-lib').Transaction;
+const Transaction = require('ripple-lib').Transaction;
-var UInt160 = require('ripple-lib').UInt160;
+const UInt160 = require('ripple-lib').UInt160;
-var Currency = require('ripple-lib').Currency;
+const Currency = require('ripple-lib').Currency;
-var Amount = require('ripple-lib').Amount;
+const Amount = require('ripple-lib').Amount;
-var PathFind = require('ripple-lib')._test.PathFind;
+const PathFind = require('ripple-lib')._test.PathFind;
-var Log = require('ripple-lib')._test.Log;
+const Log = require('ripple-lib')._test.Log;
 
-var options, remote, callback;
+let options, remote, callback;
 
-var ADDRESS = 'r4qLSAzv4LZ9TLsR7diphGwKnSEAMQTSjS';
+const ADDRESS = 'r4qLSAzv4LZ9TLsR7diphGwKnSEAMQTSjS';
-var LEDGER_INDEX = 9592219;
+const LEDGER_INDEX = 9592219;
-var LEDGER_HASH =
+const LEDGER_HASH =
   'B4FD84A73DBD8F0DA9E320D137176EBFED969691DC0AAC7882B76B595A0841AE';
-var PAGING_MARKER =
+const PAGING_MARKER =
   '29F992CC252056BF690107D1E8F2D9FBAFF29FF107B62B1D1F4E4E11ADF2CC73';
-var TRANSACTION_HASH =
+const TRANSACTION_HASH =
   '14576FFD5D59FFA73CAA90547BE4DE09926AAB59E981306C32CCE04408CBF8EA';
 
 describe('Remote', function() {
-  var initialLogEngine = Log.getEngine();
+  let initialLogEngine = Log.getEngine();
 
   beforeEach(function() {
     options = {
@@ -291,7 +291,7 @@ describe('Remote', function() {
   });
 
   it('Automatic transactions subscription', function(done) {
-    var i = 0;
+    let i = 0;
 
     remote.request = function(request) {
       switch (++i) {
@@ -365,7 +365,7 @@ describe('Remote', function() {
   });
 
   it('Set state', function() {
-    var i = 0;
+    let i = 0;
     remote.on('state', function(state) {
       switch (++i) {
         case 1:
@@ -399,10 +399,10 @@ describe('Remote', function() {
   });
 
   it('Add server', function() {
-    var server = remote.addServer('wss://s1.ripple.com:443');
+    const server = remote.addServer('wss://s1.ripple.com:443');
     assert(server instanceof Server);
 
-    var i = 0;
+    let i = 0;
     remote.once('connect', function() {
       assert.strictEqual(remote._connection_count, 1);
       ++i;
@@ -418,7 +418,7 @@ describe('Remote', function() {
     assert.strictEqual(i, 2, 'Remote did not receive all server events');
   });
   it('Add server -- primary server', function() {
-    var server = remote.addServer({
+    const server = remote.addServer({
       host: 's1.ripple.com',
       port: 443,
       secure: true,
@@ -429,7 +429,7 @@ describe('Remote', function() {
     assert.strictEqual(remote._servers.length, 2);
     assert.strictEqual(remote._servers[1], server);
 
-    var i = 0;
+    let i = 0;
     remote.once('connect', function() {
       assert.strictEqual(remote._connection_count, 1);
       assert.strictEqual(remote._primary_server, server);
@@ -447,7 +447,7 @@ describe('Remote', function() {
   it('Connect', function() {
     remote.addServer('wss://s1.ripple.com:443');
 
-    var i = 0;
+    let i = 0;
     remote._servers.forEach(function(s) {
       s.connect = function() {
         ++i;
@@ -463,7 +463,7 @@ describe('Remote', function() {
   it('Connect -- with callback', function(done) {
     remote.addServer('wss://s1.ripple.com:443');
 
-    var i = 0;
+    let i = 0;
     remote._servers.forEach(function(s) {
       s.connect = function() {
         ++i;
@@ -488,7 +488,7 @@ describe('Remote', function() {
   it('Disconnect', function() {
     remote.addServer('wss://s1.ripple.com:443');
 
-    var i = 0;
+    let i = 0;
     remote._servers.forEach(function(s) {
       s.disconnect = function() {
         ++i;
@@ -504,7 +504,7 @@ describe('Remote', function() {
   it('Disconnect -- with callback', function(done) {
     remote.addServer('wss://s1.ripple.com:443');
 
-    var i = 0;
+    let i = 0;
     remote._servers.forEach(function(s) {
       s.disconnect = function() {
         ++i;
@@ -524,7 +524,7 @@ describe('Remote', function() {
   it('Disconnect -- unconnected', function(done) {
     remote.addServer('wss://s1.ripple.com:443');
 
-    var i = 0;
+    let i = 0;
     remote._servers.forEach(function(s) {
       s.disconnect = function() {
         ++i;
@@ -543,7 +543,7 @@ describe('Remote', function() {
   });
 
   it('Handle server message -- ledger', function() {
-    var message = {
+    const message = {
       type: 'ledgerClosed',
       fee_base: 10,
       fee_ref: 10,
@@ -565,7 +565,7 @@ describe('Remote', function() {
     remote._servers[0].emit('message', message);
   });
   it('Handle server message -- ledger', function(done) {
-    var message = {
+    const message = {
       type: 'ledgerClosed',
       fee_base: 10,
       fee_ref: 10,
@@ -590,7 +590,7 @@ describe('Remote', function() {
     });
   });
   it('Handle server message -- server status', function() {
-    var message = {
+    const message = {
       type: 'serverStatus',
       load_base: 256,
       load_factor: 256,
@@ -604,7 +604,7 @@ describe('Remote', function() {
     remote._servers[0].emit('connect');
   });
   it('Handle server message -- transaction', function() {
-    var message = require('./fixtures/transaction');
+    const message = require('./fixtures/transaction');
 
     remote.once('transaction', function(l) {
       assert.deepEqual(l, message);
@@ -613,8 +613,8 @@ describe('Remote', function() {
     remote._servers[0].emit('message', message);
   });
   it('Handle server message -- transaction -- duplicate hashes', function() {
-    var message = require('./fixtures/transaction');
+    const message = require('./fixtures/transaction');
-    var i = 0;
+    let i = 0;
 
     remote.once('transaction', function(l) {
       assert.deepEqual(l, message);
@@ -629,9 +629,9 @@ describe('Remote', function() {
   });
   it('Handle server message -- '
      + 'transaction -- with account notification', function() {
-    var message = require('./fixtures/transaction');
+    const message = require('./fixtures/transaction');
-    var i = 0;
+    let i = 0;
-    var account = remote.addAccount(message.transaction.Account);
+    const account = remote.addAccount(message.transaction.Account);
 
     account.once('transaction', function(t) {
       assert.deepEqual(t, message);
@@ -649,9 +649,9 @@ describe('Remote', function() {
   });
   it('Handle server message -- '
      + 'transaction proposed -- with account notification', function() {
-    var message = require('./fixtures/transaction-proposed');
+    const message = require('./fixtures/transaction-proposed');
-    var i = 0;
+    let i = 0;
-    var account = remote.addAccount(message.transaction.Account);
+    const account = remote.addAccount(message.transaction.Account);
 
     account.once('transaction', function(t) {
       assert.deepEqual(t, message);
@@ -669,9 +669,9 @@ describe('Remote', function() {
   });
   it('Handle server message -- transaction -- with orderbook notification',
      function() {
-    var message = require('./fixtures/transaction-offercreate');
+    const message = require('./fixtures/transaction-offercreate');
-    var i = 0;
+    let i = 0;
-    var orderbook = remote.createOrderBook({
+    const orderbook = remote.createOrderBook({
       currency_gets: 'USD',
       issuer_gets: 'rJy64aCJLP3vf8o3WPKn4iQKtfpjh6voAR',
       currency_pays: 'XRP'
@@ -694,15 +694,15 @@ describe('Remote', function() {
     assert.strictEqual(i, 2);
   });
   it('Handle server message -- path find', function() {
-    var message = require('./fixtures/pathfind');
+    const message = require('./fixtures/pathfind');
-    var i = 0;
+    let i = 0;
 
-    var amount = Amount.from_json({
+    const amount = Amount.from_json({
       currency: 'USD',
       issuer: 'rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B',
       value: '0.001'
     });
-    var path = new PathFind(remote,
+    const path = new PathFind(remote,
       'r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59',
       'r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59',
       amount
@@ -728,7 +728,7 @@ describe('Remote', function() {
     Log.setEngine(Log.engines.none);
 
     require('./fixtures/pathfind');
-    var i = 0;
+    let i = 0;
 
     remote.on('error', function(e) {
       assert(/^Unexpected response from remote/.test(e.message));
@@ -751,7 +751,7 @@ describe('Remote', function() {
       s._connected = true;
     });
 
-    var message = {
+    const message = {
       type: 'ledgerClosed',
       fee_base: 10,
       fee_ref: 10,
@@ -782,7 +782,7 @@ describe('Remote', function() {
     assert.strictEqual(remote.getServer(), null);
   });
   it('Get server -- primary server', function() {
-    var server = remote.addServer({
+    const server = remote.addServer({
       host: 'sasdf.ripple.com',
       port: 443,
       secure: true,
@@ -796,28 +796,28 @@ describe('Remote', function() {
   });
 
   it('Parse binary transaction', function() {
-    var binaryTransaction = require('./fixtures/binary-transaction.json');
+    const binaryTransaction = require('./fixtures/binary-transaction.json');
 
-    var parsedSourceTag = Remote.parseBinaryTransaction(
+    const parsedSourceTag = Remote.parseBinaryTransaction(
       binaryTransaction.PaymentWithSourceTag.binary);
     assert.deepEqual(parsedSourceTag,
                      binaryTransaction.PaymentWithSourceTag.parsed);
 
-    var parsedMemosAndPaths = Remote.parseBinaryTransaction(
+    const parsedMemosAndPaths = Remote.parseBinaryTransaction(
       binaryTransaction.PaymentWithMemosAndPaths.binary);
     assert.deepEqual(parsedMemosAndPaths,
                      binaryTransaction.PaymentWithMemosAndPaths.parsed);
 
-    var parsedPartialPayment = Remote.parseBinaryTransaction(
+    const parsedPartialPayment = Remote.parseBinaryTransaction(
       binaryTransaction.PartialPayment.binary);
     assert.deepEqual(parsedPartialPayment,
                      binaryTransaction.PartialPayment.parsed);
 
-    var parsedOfferCreate = Remote.parseBinaryTransaction(
+    const parsedOfferCreate = Remote.parseBinaryTransaction(
       binaryTransaction.OfferCreate.binary);
     assert.deepEqual(parsedOfferCreate, binaryTransaction.OfferCreate.parsed);
 
-    var parsedPartialPaymentWithXRPDelieveredAmount =
+    const parsedPartialPaymentWithXRPDelieveredAmount =
       Remote.parseBinaryTransaction(
         binaryTransaction.PartialPaymentWithXRPDeliveredAmount.binary);
 
@@ -828,40 +828,40 @@ describe('Remote', function() {
   });
 
   it('Parse binary account transaction', function() {
-    var binaryAccountTransaction =
+    const binaryAccountTransaction =
       require('./fixtures/binary-account-transaction.json');
 
-    var parsed = Remote.parseBinaryAccountTransaction(
+    const parsed = Remote.parseBinaryAccountTransaction(
       binaryAccountTransaction.OfferCreate.binary);
     assert.deepEqual(parsed, binaryAccountTransaction.OfferCreate.parsed);
 
-    var parsedPartialPayment = Remote.parseBinaryAccountTransaction(
+    const parsedPartialPayment = Remote.parseBinaryAccountTransaction(
       binaryAccountTransaction.PartialPayment.binary);
     assert.deepEqual(parsedPartialPayment,
                      binaryAccountTransaction.PartialPayment.parsed);
 
-    var parsedPayment = Remote.parseBinaryAccountTransaction(
+    const parsedPayment = Remote.parseBinaryAccountTransaction(
       binaryAccountTransaction.Payment.binary);
     assert.deepEqual(parsedPayment, binaryAccountTransaction.Payment.parsed);
   });
 
   it('Parse binary ledger', function() {
-    var binaryLedgerData = require('./fixtures/binary-ledger-data.json');
+    const binaryLedgerData = require('./fixtures/binary-ledger-data.json');
 
-    var parsedAccountRoot =
+    const parsedAccountRoot =
       Remote.parseBinaryLedgerData(binaryLedgerData.AccountRoot.binary);
     assert.deepEqual(parsedAccountRoot, binaryLedgerData.AccountRoot.parsed);
 
-    var parsedOffer =
+    const parsedOffer =
       Remote.parseBinaryLedgerData(binaryLedgerData.Offer.binary);
     assert.deepEqual(parsedOffer, binaryLedgerData.Offer.parsed);
 
-    var parsedDirectoryNode =
+    const parsedDirectoryNode =
       Remote.parseBinaryLedgerData(binaryLedgerData.DirectoryNode.binary);
     assert.deepEqual(parsedDirectoryNode,
                      binaryLedgerData.DirectoryNode.parsed);
 
-    var parsedRippleState =
+    const parsedRippleState =
       Remote.parseBinaryLedgerData(binaryLedgerData.RippleState.binary);
     assert.deepEqual(parsedRippleState, binaryLedgerData.RippleState.parsed);
   });
@@ -906,14 +906,14 @@ describe('Remote', function() {
   });
 
   it('Initiate request', function() {
-    var request = remote.requestServerInfo();
+    const request = remote.requestServerInfo();
 
     assert.deepEqual(request.message, {
       command: 'server_info',
       id: undefined
     });
 
-    var i = 0;
+    let i = 0;
     remote._connected = true;
     remote._servers[0]._connected = true;
     remote._servers[0]._request = function() {
@@ -924,14 +924,14 @@ describe('Remote', function() {
     assert.strictEqual(i, 1, 'Did not initiate request');
   });
   it('Initiate request -- with request name', function() {
-    var request = remote.request('server_info');
+    const request = remote.request('server_info');
 
     assert.deepEqual(request.message, {
       command: 'server_info',
       id: undefined
     });
 
-    var i = 0;
+    let i = 0;
     remote._connected = true;
     remote._servers[0]._connected = true;
     remote._servers[0]._request = function() {
@@ -955,7 +955,7 @@ describe('Remote', function() {
     });
   });
   it('Initiate request -- set non-existent servers', function() {
-    var request = remote.requestServerInfo();
+    const request = remote.requestServerInfo();
     request.setServer('wss://s-east.ripple.com:443');
     assert.strictEqual(request.server, null);
     assert.throws(function() {
@@ -965,14 +965,14 @@ describe('Remote', function() {
   });
 
   it('Construct ledger request', function() {
-    var request = remote.requestLedger();
+    const request = remote.requestLedger();
     assert.deepEqual(request.message, {
       command: 'ledger',
       id: undefined
     });
   });
   it('Construct ledger request -- with ledger index', function() {
-    var request = remote.requestLedger({ledger: 1});
+    let request = remote.requestLedger({ledger: 1});
     assert.deepEqual(request.message, {
       command: 'ledger',
       id: undefined,
@@ -997,7 +997,7 @@ describe('Remote', function() {
     });
   });
   it('Construct ledger request -- with ledger hash', function() {
-    var request = remote.requestLedger({ledger: LEDGER_HASH});
+    let request = remote.requestLedger({ledger: LEDGER_HASH});
     assert.deepEqual(request.message, {
       command: 'ledger',
       id: undefined,
@@ -1021,7 +1021,7 @@ describe('Remote', function() {
     });
   });
   it('Construct ledger request -- with ledger identifier', function() {
-    var request = remote.requestLedger({ledger: 'validated'});
+    let request = remote.requestLedger({ledger: 'validated'});
 
     assert.deepEqual(request.message, {
       command: 'ledger',
@@ -1054,7 +1054,7 @@ describe('Remote', function() {
     });
   });
   it('Construct ledger request -- with transactions', function() {
-    var request = remote.requestLedger({
+    let request = remote.requestLedger({
       ledger: 'validated',
       transactions: true
     });
@@ -1067,21 +1067,21 @@ describe('Remote', function() {
   });
 
   it('Construct ledger_closed request', function() {
-    var request = remote.requestLedgerClosed();
+    let request = remote.requestLedgerClosed();
     assert.deepEqual(request.message, {
       command: 'ledger_closed',
       id: undefined
     });
   });
   it('Construct ledger_header request', function() {
-    var request = remote.requestLedgerHeader();
+    let request = remote.requestLedgerHeader();
     assert.deepEqual(request.message, {
       command: 'ledger_header',
       id: undefined
     });
   });
   it('Construct ledger_current request', function() {
-    var request = remote.requestLedgerCurrent();
+    let request = remote.requestLedgerCurrent();
     assert.deepEqual(request.message, {
       command: 'ledger_current',
       id: undefined
@@ -1089,7 +1089,7 @@ describe('Remote', function() {
   });
 
   it('Construct ledger_data request -- with ledger hash', function() {
-    var request = remote.requestLedgerData({
+    let request = remote.requestLedgerData({
       ledger: LEDGER_HASH,
       limit: 5
     });
@@ -1104,7 +1104,7 @@ describe('Remote', function() {
   });
 
   it('Construct ledger_data request -- with ledger index', function() {
-    var request = remote.requestLedgerData({
+    let request = remote.requestLedgerData({
       ledger: LEDGER_INDEX,
       limit: 5
     });
@@ -1119,7 +1119,7 @@ describe('Remote', function() {
   });
 
   it('Construct ledger_data request -- no binary', function() {
-    var request = remote.requestLedgerData({
+    let request = remote.requestLedgerData({
       ledger: LEDGER_HASH,
       limit: 5,
       binary: false
@@ -1135,7 +1135,7 @@ describe('Remote', function() {
   });
 
   it('Construct server_info request', function() {
-    var request = remote.requestServerInfo();
+    let request = remote.requestServerInfo();
     assert.deepEqual(request.message, {
       command: 'server_info',
       id: undefined
@@ -1143,7 +1143,7 @@ describe('Remote', function() {
   });
 
   it('Construct peers request', function() {
-    var request = remote.requestPeers();
+    let request = remote.requestPeers();
     assert.deepEqual(request.message, {
       command: 'peers',
       id: undefined
@@ -1151,7 +1151,7 @@ describe('Remote', function() {
   });
 
   it('Construct connection request', function() {
-    var request = remote.requestConnect('0.0.0.0', '443');
+    let request = remote.requestConnect('0.0.0.0', '443');
     assert.deepEqual(request.message, {
       command: 'connect',
       id: undefined,
@@ -1161,7 +1161,7 @@ describe('Remote', function() {
   });
 
   it('Construct unl_add request', function() {
-    var request = remote.requestUnlAdd('0.0.0.0');
+    let request = remote.requestUnlAdd('0.0.0.0');
     assert.deepEqual(request.message, {
       command: 'unl_add',
       node: '0.0.0.0',
@@ -1170,7 +1170,7 @@ describe('Remote', function() {
   });
 
   it('Construct unl_list request', function() {
-    var request = remote.requestUnlList();
+    let request = remote.requestUnlList();
     assert.deepEqual(request.message, {
       command: 'unl_list',
       id: undefined
@@ -1178,7 +1178,7 @@ describe('Remote', function() {
   });
 
   it('Construct unl_delete request', function() {
-    var request = remote.requestUnlDelete('0.0.0.0');
+    let request = remote.requestUnlDelete('0.0.0.0');
     assert.deepEqual(request.message, {
       command: 'unl_delete',
       node: '0.0.0.0',
@@ -1187,7 +1187,7 @@ describe('Remote', function() {
   });
 
   it('Construct subscribe request', function() {
-    var request = remote.requestSubscribe(['server', 'ledger']);
+    let request = remote.requestSubscribe(['server', 'ledger']);
     assert.deepEqual(request.message, {
       command: 'subscribe',
       id: undefined,
@@ -1195,7 +1195,7 @@ describe('Remote', function() {
     });
   });
   it('Construct unsubscribe request', function() {
-    var request = remote.requestUnsubscribe(['server', 'ledger']);
+    let request = remote.requestUnsubscribe(['server', 'ledger']);
     assert.deepEqual(request.message, {
       command: 'unsubscribe',
       id: undefined,
@@ -1204,14 +1204,14 @@ describe('Remote', function() {
   });
 
   it('Construct ping request', function() {
-    var request = remote.requestPing();
+    let request = remote.requestPing();
     assert.deepEqual(request.message, {
       command: 'ping',
       id: undefined
     });
   });
   it('Construct ping request -- with server', function() {
-    var request = remote.requestPing('wss://s1.ripple.com:443');
+    let request = remote.requestPing('wss://s1.ripple.com:443');
     assert.strictEqual(request.server, remote._servers[0]);
     assert.deepEqual(request.message, {
       command: 'ping',
@@ -1220,7 +1220,7 @@ describe('Remote', function() {
   });
 
   it('Construct account_currencies request -- with ledger index', function() {
-    var request = remote.requestAccountCurrencies({
+    let request = remote.requestAccountCurrencies({
       account: ADDRESS
     });
     assert.strictEqual(request.message.command, 'account_currencies');
@@ -1228,7 +1228,7 @@ describe('Remote', function() {
   });
 
   it('Construct account_info request -- with ledger index', function() {
-    var request = remote.requestAccountInfo({
+    let request = remote.requestAccountInfo({
       account: ADDRESS,
       ledger: 9592219
     });
@@ -1237,7 +1237,7 @@ describe('Remote', function() {
     assert.strictEqual(request.message.ledger_index, 9592219);
   });
   it('Construct account_info request -- with ledger hash', function() {
-    var request = remote.requestAccountInfo({
+    let request = remote.requestAccountInfo({
       account: ADDRESS,
       ledger: LEDGER_HASH
     });
@@ -1246,7 +1246,7 @@ describe('Remote', function() {
     assert.strictEqual(request.message.ledger_hash, LEDGER_HASH);
   });
   it('Construct account_info request -- with ledger identifier', function() {
-    var request = remote.requestAccountInfo({
+    let request = remote.requestAccountInfo({
       account: ADDRESS,
       ledger: 'validated'
     });
@@ -1256,7 +1256,7 @@ describe('Remote', function() {
   });
 
   it('Construct account balance request -- with ledger index', function() {
-    var request = remote.requestAccountBalance({
+    let request = remote.requestAccountBalance({
       account: ADDRESS,
       ledger: 9592219
     });
@@ -1265,7 +1265,7 @@ describe('Remote', function() {
     assert.strictEqual(request.message.ledger_index, 9592219);
   });
   it('Construct account balance request -- with ledger hash', function() {
-    var request = remote.requestAccountBalance({
+    let request = remote.requestAccountBalance({
       account: ADDRESS,
       ledger: LEDGER_HASH
     });
@@ -1274,7 +1274,7 @@ describe('Remote', function() {
     assert.strictEqual(request.message.ledger_hash, LEDGER_HASH);
   });
   it('Construct account balance request -- with ledger identifier', function() {
-    var request = remote.requestAccountBalance({
+    let request = remote.requestAccountBalance({
       account: ADDRESS,
       ledger: 'validated'
     });
@@ -1284,18 +1284,18 @@ describe('Remote', function() {
   });
 
   it('Construct account flags request', function() {
-    var request = remote.requestAccountFlags({account: ADDRESS});
+    let request = remote.requestAccountFlags({account: ADDRESS});
     assert.strictEqual(request.message.command, 'ledger_entry');
     assert.strictEqual(request.message.account_root, ADDRESS);
   });
   it('Construct account owner count request', function() {
-    var request = remote.requestOwnerCount({account: ADDRESS});
+    let request = remote.requestOwnerCount({account: ADDRESS});
     assert.strictEqual(request.message.command, 'ledger_entry');
     assert.strictEqual(request.message.account_root, ADDRESS);
   });
 
   it('Construct account_lines request', function() {
-    var request = remote.requestAccountLines({account: ADDRESS});
+    let request = remote.requestAccountLines({account: ADDRESS});
     assert.deepEqual(request.message, {
       command: 'account_lines',
       id: undefined,
@@ -1303,7 +1303,7 @@ describe('Remote', function() {
     });
   });
   it('Construct account_lines request -- with peer', function() {
-    var request = remote.requestAccountLines({
+    let request = remote.requestAccountLines({
       account: ADDRESS,
       peer: ADDRESS
     });
@@ -1315,7 +1315,7 @@ describe('Remote', function() {
     });
   });
   it('Construct account_lines request -- with limit', function() {
-    var request = remote.requestAccountLines({
+    let request = remote.requestAccountLines({
       account: ADDRESS,
       limit: 100
     });
@@ -1327,7 +1327,7 @@ describe('Remote', function() {
     });
   });
   it('Construct account_lines request -- with limit and marker', function() {
-    var request = remote.requestAccountLines({
+    let request = remote.requestAccountLines({
       account: ADDRESS,
       limit: 100,
       marker: PAGING_MARKER,
@@ -1408,7 +1408,7 @@ describe('Remote', function() {
     }, 'A ledger_index or ledger_hash must be provided when using a marker');
   });
   it('Construct account_lines request -- with callback', function() {
-    var request = remote.requestAccountLines({
+    let request = remote.requestAccountLines({
       account: ADDRESS
     }, callback);
 
@@ -1420,7 +1420,7 @@ describe('Remote', function() {
   });
 
   it('Construct account_tx request', function() {
-    var request = remote.requestAccountTransactions({
+    let request = remote.requestAccountTransactions({
       account: UInt160.ACCOUNT_ONE,
       ledger_index_min: -1,
       ledger_index_max: -1,
@@ -1456,7 +1456,7 @@ describe('Remote', function() {
     });
   });
   it('Construct account_tx request -- no binary', function() {
-    var request = remote.requestAccountTransactions({
+    let request = remote.requestAccountTransactions({
       account: UInt160.ACCOUNT_ONE,
       ledger_index_min: -1,
       ledger_index_max: -1,
@@ -1480,7 +1480,7 @@ describe('Remote', function() {
   });
 
   it('Construct account_offers request -- no binary', function() {
-    var request = remote.requestAccountOffers({account: ADDRESS});
+    let request = remote.requestAccountOffers({account: ADDRESS});
     assert.deepEqual(request.message, {
       command: 'account_offers',
       id: undefined,
@@ -1489,7 +1489,7 @@ describe('Remote', function() {
   });
 
   it('Construct offer request -- with ledger index', function() {
-    var request = remote.requestOffer({
+    let request = remote.requestOffer({
       index: TRANSACTION_HASH, ledger: LEDGER_INDEX
     });
     assert.strictEqual(request.message.command, 'ledger_entry');
@@ -1497,7 +1497,7 @@ describe('Remote', function() {
     assert.strictEqual(request.message.ledger_index, LEDGER_INDEX);
   });
   it('Construct offer request -- with ledger index and sequence', function() {
-    var request = remote.requestOffer({
+    let request = remote.requestOffer({
       account: ADDRESS, ledger: LEDGER_INDEX, sequence: 5
     });
     assert.strictEqual(request.message.command, 'ledger_entry');
@@ -1506,7 +1506,7 @@ describe('Remote', function() {
     assert.strictEqual(request.message.ledger_index, LEDGER_INDEX);
   });
   it('Construct offer request -- with ledger hash', function() {
-    var request = remote.requestOffer({
+    let request = remote.requestOffer({
       account: ADDRESS, ledger: LEDGER_HASH, sequence: 5
     });
     assert.strictEqual(request.message.command, 'ledger_entry');
@@ -1516,7 +1516,7 @@ describe('Remote', function() {
   });
   it('Construct offer request -- with ledger identifier and sequence',
      function() {
-    var request = remote.requestOffer({
+    let request = remote.requestOffer({
       account: ADDRESS, ledger: 'validated', sequence: 5
     });
     assert.strictEqual(request.message.command, 'ledger_entry');
@@ -1526,7 +1526,7 @@ describe('Remote', function() {
   });
 
   it('Construct book_offers request', function() {
-    var request = remote.requestBookOffers({
+    let request = remote.requestBookOffers({
       taker_gets: {
         currency: 'USD',
         issuer: ADDRESS
@@ -1551,7 +1551,7 @@ describe('Remote', function() {
   });
 
   it('Construct book_offers request -- with ledger and limit', function() {
-    var request = remote.requestBookOffers({
+    let request = remote.requestBookOffers({
       taker_gets: {
         currency: 'USD',
         issuer: ADDRESS
@@ -1580,7 +1580,7 @@ describe('Remote', function() {
   });
 
   it('Construct tx request', function() {
-    var request = remote.requestTransaction({
+    let request = remote.requestTransaction({
       hash: TRANSACTION_HASH
     });
 
@@ -1592,7 +1592,7 @@ describe('Remote', function() {
     });
   });
   it('Construct tx request -- no binary', function() {
-    var request = remote.requestTransaction({
+    let request = remote.requestTransaction({
       hash: TRANSACTION_HASH,
       binary: false
     });
@@ -1606,7 +1606,7 @@ describe('Remote', function() {
   });
 
   it('Construct transaction_entry request', function() {
-    var request = remote.requestTransactionEntry({
+    let request = remote.requestTransactionEntry({
       hash: TRANSACTION_HASH
     });
 
@@ -1618,7 +1618,7 @@ describe('Remote', function() {
     });
   });
   it('Construct transaction_entry request -- with ledger index', function() {
-    var request = remote.requestTransactionEntry({
+    let request = remote.requestTransactionEntry({
       hash: TRANSACTION_HASH,
       ledger: 1
     });
@@ -1631,7 +1631,7 @@ describe('Remote', function() {
     });
   });
   it('Construct transaction_entry request -- with ledger hash', function() {
-    var request = remote.requestTransactionEntry({
+    let request = remote.requestTransactionEntry({
       hash: TRANSACTION_HASH,
       ledger: LEDGER_HASH
     });
@@ -1653,7 +1653,7 @@ describe('Remote', function() {
   });
 
   it('Construct tx_history request', function() {
-    var request = remote.requestTransactionHistory({
+    let request = remote.requestTransactionHistory({
       start: 1
     });
 
@@ -1665,7 +1665,7 @@ describe('Remote', function() {
   });
 
   it('Construct wallet_accounts request', function() {
-    var request = remote.requestWalletAccounts({
+    let request = remote.requestWalletAccounts({
       seed: 'shmnpxY42DaoyNbNQDoGuymNT1T9U'
     });
 
@@ -1686,7 +1686,7 @@ describe('Remote', function() {
   });
 
   it('Construct sign request', function() {
-    var request = remote.requestSign({
+    let request = remote.requestSign({
       secret: 'shmnpxY42DaoyNbNQDoGuymNT1T9U',
       tx_json: {
         Flags: 0,
@@ -1722,7 +1722,7 @@ describe('Remote', function() {
   });
 
   it('Construct submit request', function() {
-    var request = remote.requestSubmit();
+    let request = remote.requestSubmit();
     assert.deepEqual(request.message, {
       command: 'submit',
       id: undefined
@@ -1730,7 +1730,7 @@ describe('Remote', function() {
   });
 
   it('Construct transaction', function() {
-    var tx = remote.createTransaction('AccountSet', {
+    let tx = remote.createTransaction('AccountSet', {
       account: 'rwLZs9MUVv28XZdYXDk9uNRUpAh1c6jij8',
       flags: 0
     });
@@ -1758,7 +1758,7 @@ describe('Remote', function() {
 
   it('Construct ledger_accept request', function() {
     remote._stand_alone = true;
-    var request = remote.requestLedgerAccept();
+    let request = remote.requestLedgerAccept();
 
     assert.deepEqual(request.message, {
       command: 'ledger_accept',
@@ -1787,7 +1787,7 @@ describe('Remote', function() {
   });
 
   it('Construct ripple balance request', function() {
-    var request = remote.requestRippleBalance({
+    let request = remote.requestRippleBalance({
       account: 'rGr9PjmVe7MqEXTSbd3njhgJc2s5vpHV54',
       issuer: 'rwxBjBC9fPzyQ9GgPZw6YYLNeRTSx5c2W6',
       ledger: 1,
@@ -1809,7 +1809,7 @@ describe('Remote', function() {
   });
 
   it('Construct ripple_path_find request', function() {
-    var request = remote.requestRipplePathFind({
+    let request = remote.requestRipplePathFind({
       src_account: 'rGr9PjmVe7MqEXTSbd3njhgJc2s5vpHV54',
       dst_account: 'rwxBjBC9fPzyQ9GgPZw6YYLNeRTSx5c2W6',
       dst_amount: '1/USD/rGr9PjmVe7MqEXTSbd3njhgJc2s5vpHV54',
@@ -1836,7 +1836,7 @@ describe('Remote', function() {
   });
 
   it('Construct path_find create request', function() {
-    var request = remote.requestPathFindCreate({
+    let request = remote.requestPathFindCreate({
       src_account: 'rGr9PjmVe7MqEXTSbd3njhgJc2s5vpHV54',
       dst_account: 'rwxBjBC9fPzyQ9GgPZw6YYLNeRTSx5c2W6',
       dst_amount: '1/USD/rGr9PjmVe7MqEXTSbd3njhgJc2s5vpHV54',
@@ -1864,7 +1864,7 @@ describe('Remote', function() {
   });
 
   it('Construct path_find close request', function() {
-    var request = remote.requestPathFindClose();
+    let request = remote.requestPathFindClose();
 
     assert.deepEqual(request.message, {
       command: 'path_find',