From 6604c717b79cf10619d97f8429363996b10b5e3a Mon Sep 17 00:00:00 2001 From: Ben Sharafian Date: Tue, 28 Feb 2017 18:29:13 +0100 Subject: [PATCH] fix: Signature is a non-signing field --- packages/ripple-binary-codec/src/enums/definitions.json | 2 +- .../ripple-binary-codec/test/signing-data-encoding-test.js | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/ripple-binary-codec/src/enums/definitions.json b/packages/ripple-binary-codec/src/enums/definitions.json index 83c78626..9ea0d152 100644 --- a/packages/ripple-binary-codec/src/enums/definitions.json +++ b/packages/ripple-binary-codec/src/enums/definitions.json @@ -903,7 +903,7 @@ "nth": 6, "isVLEncoded": true, "isSerialized": true, - "isSigningField": true, + "isSigningField": false, "type": "Blob" } ], diff --git a/packages/ripple-binary-codec/test/signing-data-encoding-test.js b/packages/ripple-binary-codec/test/signing-data-encoding-test.js index a41ef8da..3686a5d0 100644 --- a/packages/ripple-binary-codec/test/signing-data-encoding-test.js +++ b/packages/ripple-binary-codec/test/signing-data-encoding-test.js @@ -10,6 +10,12 @@ const tx_json = { Flags: 2147483648, Sequence: 1, TransactionType: 'Payment', + TxnSignature: '30440220718D264EF05CAED7C781FF6DE298DCAC68D002562C9BF3A07C1' + + 'E721B420C0DAB02203A5A4779EF4D2CCC7BC3EF886676D803A9981B928D3B8ACA483B80' + + 'ECA3CD7B9B', + Signature: '30440220718D264EF05CAED7C781FF6DE298DCAC68D002562C9BF3A07C1E72' + + '1B420C0DAB02203A5A4779EF4D2CCC7BC3EF886676D803A9981B928D3B8ACA483B80ECA' + + '3CD7B9B', SigningPubKey: 'ED5F5AC8B98974A3CA843326D9B88CEBD0560177B973EE0B149F782CFAA06DC66A' };