From e6782f456305c3028f3adf53227c98f3f29a0138 Mon Sep 17 00:00:00 2001 From: Matthew Fettig Date: Mon, 23 Jun 2014 11:30:06 -0700 Subject: [PATCH 1/4] [FIX] vault client: set SJCL test entropy random string to base64 --- test/vault-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/vault-test.js b/test/vault-test.js index 737c4a97..c064b31d 100644 --- a/test/vault-test.js +++ b/test/vault-test.js @@ -113,7 +113,7 @@ var blob = new Blob(); //must be set for self signed certs process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'; while(!sjcl.random.isReady()) { - sjcl.random.addEntropy(require('crypto').randomBytes(128).toString()); //add entropy to seed the generator + sjcl.random.addEntropy(require('crypto').randomBytes(128).toString('base64')); //add entropy to seed the generator } var mockRippleTxt; From 47094f84d75e37bf4cc231723c89403572561e23 Mon Sep 17 00:00:00 2001 From: Geert Weening Date: Mon, 23 Jun 2014 12:01:13 -0700 Subject: [PATCH 2/4] [DOC] update changelog with currency changes --- HISTORY.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/HISTORY.md b/HISTORY.md index d423d7fb..1465d357 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -21,6 +21,9 @@ parseBinary: false } ``` ++ Added full currency name support, e.g. `Currency.from_json('XRP').to_human({full_name:'Ripples'})` will return `XRP - Ripples` + ++ Improved interest bearing currency support, e.g. `Currency.from_human('USD - US Dollar (2.5%pa)')` + Improve test coverage From 309957a6cfb2ea24f489d08c5c5a27a6fb86790a Mon Sep 17 00:00:00 2001 From: shekenahglory Date: Mon, 23 Jun 2014 13:16:19 -0700 Subject: [PATCH 3/4] Update HISTORY.md --- HISTORY.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/HISTORY.md b/HISTORY.md index d423d7fb..dd256c5d 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -24,6 +24,9 @@ + Improve test coverage ++ Added blob vault client. The vault client facilitates interaction with ripple's namespace and blob vault or 3rd party blob vaults using ripple's blob vault software (https://github.com/ripple/ripple-blobvault). A list of the available functions can be found at [docs/VAULTCLIENT.md](docs/VAULTCLIENT.md) + + ##0.7.35 + `LastLedgerSequence` is set by default on outgoing transactions. This refers to the last valid ledger index (AKA sequence) for a transaction. By default, this index is set to the current index (at submission time) plus 8. In theory, this allows ripple-lib to deterministically fail a transaction whose submission request timed out, but whose associated server continues to emit ledger_closed events. From 3ebcadfad410bdae4ab16b34ff2c36dcd9241e68 Mon Sep 17 00:00:00 2001 From: Matthew Fettig Date: Mon, 23 Jun 2014 13:44:16 -0700 Subject: [PATCH 4/4] [FIX] vault client: rippleTxt test request diverted to offline mock --- test/vault-test.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/test/vault-test.js b/test/vault-test.js index c064b31d..7d664702 100644 --- a/test/vault-test.js +++ b/test/vault-test.js @@ -117,6 +117,7 @@ while(!sjcl.random.isReady()) { } var mockRippleTxt; +var mockRippleTxt2; var mockAuthSign; var mockRegister; var mockBlob; @@ -129,7 +130,14 @@ var mockProfile; var mockDelete; if (!online) { - mockRippleTxt = nock('https://' + exampleData.domain) + mockRippleTxt = nock('https://ripple.com') + .persist() + .get('/ripple.txt') + .reply(200, rippleTxtRes, { + 'Content-Type': 'text/plain' + }); + + mockRippleTxt2 = nock('https://' + exampleData.domain) .persist() .get('/ripple.txt') .reply(200, rippleTxtRes, {