ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-20 04:05:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lint errors in transaction-test.js and transaction-manager-test.js

Browse Source
This commit is contained in:
Chris Clark
2015-04-06 16:56:43 -07:00
parent fe7e30b737
commit 56d8aa797a
3 changed files with 165 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@@ -27,7 +27,7 @@
"devDependencies": {
"assert-diff": "^1.0.1",
"coveralls": "~2.10.0",
"eslint": "^0.13.0",
"eslint": "^0.18.0",
"gulp": "~3.8.10",
"gulp-bump": "~0.1.13",
"gulp-clean-dest": "^0.1.0",

1
test/transaction-manager-test.js
View File

@@ -57,6 +57,7 @@ describe('TransactionManager', function() {
try {
c.send(JSON.stringify(v));
} catch (e) {
// empty
}
};
c.sendResponse = function(baseResponse, ext) {

134
test/transaction-test.js
View File

@@ -1,5 +1,6 @@
/* eslint-disable max-len */
'use strict';
var assert = require('assert');
var Amount = require('ripple-lib').Amount;
var Transaction = require('ripple-lib').Transaction;
var TransactionQueue = require('ripple-lib').TransactionQueue;
var Remote = require('ripple-lib').Remote;
@@ -18,7 +19,8 @@ var transactionResult = {
metadata: {
AffectedNodes: [ ],
TransactionIndex: 0,
TransactionResult: 'tesSUCCESS' },
TransactionResult: 'tesSUCCESS'
},
tx_json: {
Account: 'rHPotLj3CNKaP4bQANcecEuT8hai3VpxfB',
Amount: '1000000',
@@ -195,7 +197,7 @@ describe('Transaction', function() {
assert.strictEqual(transaction._accountSecret('rpzT237Ctpaa58KieifoK8RyBmmRwEcfhK'), 'shY1njzHAXp8Qt3bpxYW6RpoZtMKP');
assert.strictEqual(transaction._accountSecret('rpdxPs9CR93eLAc5DTvAgv4S9XJ1CzKj1a'), 'ssboTJezioTq8obyvDU9tVo95NGGQ');
assert.strictEqual(transaction._accountSecret('rExistNot'), void(0));
assert.strictEqual(transaction._accountSecret('rExistNot'), undefined);
});
it('Get fee units', function() {
@@ -241,7 +243,7 @@ describe('Transaction', function() {
it('Compute fee, no remote', function() {
var transaction = new Transaction();
assert.strictEqual(transaction._computeFee(10), void(0));
assert.strictEqual(transaction._computeFee(10), undefined);
});
it('Compute fee - no connected server', function() {
@@ -266,7 +268,7 @@ describe('Transaction', function() {
var transaction = new Transaction(remote);
assert.strictEqual(transaction._computeFee(), void(0));
assert.strictEqual(transaction._computeFee(), undefined);
});
it('Compute fee - one connected server', function() {
@@ -433,7 +435,7 @@ describe('Transaction', function() {
remote.trusted = true;
remote.local_signing = true;
transaction.SigningPubKey = void(0);
transaction.SigningPubKey = undefined;
transaction.tx_json.Account = 'rMWwx3Ma16HnqSd4H6saPisihX9aKpXxHJ';
transaction._secret = 'sh2pTicynUEG46jjR4EoexHcQEoijX';
@@ -479,7 +481,7 @@ describe('Transaction', function() {
transaction.tx_json.Account = 'rMWwx3Ma16HnqSd4H6saPisihX9aKpXxHJ';
transaction._secret = 'sh2pTicynUEG46jjR4EoexHcQEoij';
assert.strictEqual(transaction.tx_json.Fee, void(0));
assert.strictEqual(transaction.tx_json.Fee, undefined);
assert(transaction.complete());
@@ -545,7 +547,7 @@ describe('Transaction', function() {
transaction.tx_json.Sequence = 1;
transaction.tx_json.TransactionType = 'AccountSet';
assert.strictEqual(transaction.signingHash(), 'D1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE')
assert.strictEqual(transaction.signingHash(), 'D1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE');
done();
});
@@ -560,7 +562,7 @@ describe('Transaction', function() {
transaction.tx_json.Sequence = 1;
transaction.tx_json.TransactionType = 'AccountSet';
assert.strictEqual(transaction.hash(), '1A860FC46D1DD9200560C64002418A4E8BBDE939957AC82D7B14D80A1C0E2EB5')
assert.strictEqual(transaction.hash(), '1A860FC46D1DD9200560C64002418A4E8BBDE939957AC82D7B14D80A1C0E2EB5');
done();
});
@@ -575,7 +577,7 @@ describe('Transaction', function() {
transaction.tx_json.Sequence = 1;
transaction.tx_json.TransactionType = 'AccountSet';
assert.strictEqual(transaction.hash('HASH_TX_SIGN'), 'D1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE')
assert.strictEqual(transaction.hash('HASH_TX_SIGN'), 'D1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE');
assert.strictEqual(transaction.hash('HASH_TX_SIGN_TESTNET'), '9FE7D27FC5B9891076B66591F99A683E01E0912986A629235459A3BD1961F341');
done();
@@ -644,7 +646,7 @@ describe('Transaction', function() {
TxnSignature: '304602210096C2F385530587DE573936CA51CB86B801A28F777C944E268212BE7341440B7F022100EBF0508A9145A56CDA7FAF314DF3BBE51C6EE450BA7E74D88516891A3608644E'
};
var expected_hash = "87366146D381AD971B97DD41CFAC1AE4670B0E996AB574B0CE18CE6467811868";
var expected_hash = '87366146D381AD971B97DD41CFAC1AE4670B0E996AB574B0CE18CE6467811868';
var transaction = Transaction.from_json(input_json);
assert.deepEqual(transaction.hash(), expected_hash);
@@ -828,7 +830,7 @@ describe('Transaction', function() {
assert.deepEqual(transaction.findId({
F1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE: transaction
}), void(0));
}), undefined);
transaction.addId('F1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE');
@@ -838,7 +840,7 @@ describe('Transaction', function() {
assert.strictEqual(transaction.findId({
Z1C15200CF532175F1890B6440AD223D3676140522BC11D2784E56760AE3B4FE: transaction
}), void(0));
}), undefined);
done();
});
@@ -852,7 +854,7 @@ describe('Transaction', function() {
it('Set DestinationTag', function() {
var transaction = new Transaction();
transaction.destinationTag('tag');
assert.strictEqual(transaction.tx_json.DestinationTag, void(0));
assert.strictEqual(transaction.tx_json.DestinationTag, undefined);
transaction.destinationTag(1);
assert.strictEqual(transaction.tx_json.DestinationTag, 1);
});
@@ -861,7 +863,7 @@ describe('Transaction', function() {
var transaction = new Transaction();
transaction.invoiceID(1);
assert.strictEqual(transaction.tx_json.InvoiceID, void(0));
assert.strictEqual(transaction.tx_json.InvoiceID, undefined);
transaction.invoiceID('DEADBEEF');
assert.strictEqual(transaction.tx_json.InvoiceID, 'DEADBEEF00000000000000000000000000000000000000000000000000000000');
@@ -874,7 +876,7 @@ describe('Transaction', function() {
var transaction = new Transaction();
transaction.clientID(1);
assert.strictEqual(transaction._clientID, void(0));
assert.strictEqual(transaction._clientID, undefined);
transaction.clientID('DEADBEEF');
assert.strictEqual(transaction._clientID, 'DEADBEEF');
@@ -884,11 +886,11 @@ describe('Transaction', function() {
var transaction = new Transaction();
transaction.lastLedger('a');
assert.strictEqual(transaction.tx_json.LastLedgerSequence, void(0));
assert.strictEqual(transaction.tx_json.LastLedgerSequence, undefined);
assert(!transaction._setLastLedger);
transaction.lastLedger(NaN);
assert.strictEqual(transaction.tx_json.LastLedgerSequence, void(0));
assert.strictEqual(transaction.tx_json.LastLedgerSequence, undefined);
assert(!transaction._setLastLedger);
transaction.lastLedger(12);
@@ -928,8 +930,6 @@ describe('Transaction', function() {
});
it('Rewrite transaction path', function() {
var transaction = new Transaction();
var path = [
{
account: 'rP51ycDJw5ZhgvdKiRjBYZKYjsyoCcHmnY',
@@ -971,7 +971,7 @@ describe('Transaction', function() {
it('Rewrite transaction path - invalid path', function() {
assert.throws(function() {
assert.strictEqual(Transaction._rewritePath(1), void(0));
assert.strictEqual(Transaction._rewritePath(1), undefined);
});
});
@@ -980,7 +980,7 @@ describe('Transaction', function() {
transaction.pathAdd(1);
assert.strictEqual(transaction.tx_json.Paths, void(0));
assert.strictEqual(transaction.tx_json.Paths, undefined);
var path = [
{
@@ -1031,7 +1031,7 @@ describe('Transaction', function() {
transaction.paths(1);
assert.strictEqual(transaction.tx_json.Paths, void(0));
assert.strictEqual(transaction.tx_json.Paths, undefined);
transaction.paths([
[{
@@ -1081,7 +1081,7 @@ describe('Transaction', function() {
it('Set SourceTag', function() {
var transaction = new Transaction();
transaction.sourceTag('tag');
assert.strictEqual(transaction.tx_json.SourceTag, void(0));
assert.strictEqual(transaction.tx_json.SourceTag, undefined);
transaction.sourceTag(1);
assert.strictEqual(transaction.tx_json.SourceTag, 1);
});
@@ -1089,7 +1089,7 @@ describe('Transaction', function() {
it('Set TransferRate', function() {
var transaction = new Transaction();
transaction.transferRate(1);
assert.strictEqual(transaction.tx_json.TransferRate, void(0));
assert.strictEqual(transaction.tx_json.TransferRate, undefined);
transaction.transferRate(1.5 * 1e9);
assert.strictEqual(transaction.tx_json.TransferRate, 1.5 * 1e9);
});
@@ -1100,33 +1100,33 @@ describe('Transaction', function() {
transaction.setFlags();
assert.strictEqual(transaction.tx_json.Flags, 0);
var transaction = new Transaction();
transaction.tx_json.TransactionType = 'Payment';
transaction.setFlags(Transaction.flags.Payment.PartialPayment);
assert.strictEqual(transaction.tx_json.Flags, 131072);
var transaction2 = new Transaction();
transaction2.tx_json.TransactionType = 'Payment';
transaction2.setFlags(Transaction.flags.Payment.PartialPayment);
assert.strictEqual(transaction2.tx_json.Flags, 131072);
var transaction = new Transaction();
transaction.tx_json.TransactionType = 'Payment';
transaction.setFlags('NoRippleDirect');
assert.strictEqual(transaction.tx_json.Flags, 65536);
var transaction3 = new Transaction();
transaction3.tx_json.TransactionType = 'Payment';
transaction3.setFlags('NoRippleDirect');
assert.strictEqual(transaction3.tx_json.Flags, 65536);
var transaction = new Transaction();
transaction.tx_json.TransactionType = 'Payment';
transaction.setFlags('PartialPayment', 'NoRippleDirect');
assert.strictEqual(transaction.tx_json.Flags, 196608);
var transaction4 = new Transaction();
transaction4.tx_json.TransactionType = 'Payment';
transaction4.setFlags('PartialPayment', 'NoRippleDirect');
assert.strictEqual(transaction4.tx_json.Flags, 196608);
var transaction = new Transaction();
transaction.tx_json.TransactionType = 'Payment';
transaction.setFlags([ 'LimitQuality', 'PartialPayment' ]);
assert.strictEqual(transaction.tx_json.Flags, 393216);
var transaction5 = new Transaction();
transaction5.tx_json.TransactionType = 'Payment';
transaction5.setFlags(['LimitQuality', 'PartialPayment']);
assert.strictEqual(transaction5.tx_json.Flags, 393216);
var transaction = new Transaction();
transaction.tx_json.TransactionType = 'Payment';
transaction.once('error', function(err) {
var transaction6 = new Transaction();
transaction6.tx_json.TransactionType = 'Payment';
transaction6.once('error', function(err) {
assert.strictEqual(err.result, 'tejInvalidFlag');
done();
});
transaction.setFlags('asdf');
transaction6.setFlags('asdf');
});
it('Add Memo', function() {
@@ -1185,10 +1185,10 @@ describe('Transaction', function() {
var transaction = new Transaction();
transaction.tx_json.TransactionType = 'Payment';
transaction.addMemo('testkey', void(0), 'testvalue');
transaction.addMemo('testkey2', void(0), 'testvalue2');
transaction.addMemo('testkey', undefined, 'testvalue');
transaction.addMemo('testkey2', undefined, 'testvalue2');
transaction.addMemo('testkey3', 'text/html');
transaction.addMemo(void(0), void(0), 'testvalue4');
transaction.addMemo(undefined, undefined, 'testvalue4');
transaction.addMemo('testkey4', 'text/html', '<html>');
var expected = [
@@ -1250,7 +1250,7 @@ describe('Transaction', function() {
transaction.tx_json.TransactionType = 'Payment';
assert.throws(function() {
transaction.addMemo(void(0), 1);
transaction.addMemo(undefined, 1);
}, /^Error: MemoFormat must be a string$/);
});
@@ -1259,7 +1259,7 @@ describe('Transaction', function() {
transaction.tx_json.TransactionType = 'Payment';
assert.throws(function() {
transaction.addMemo(void(0), 'России');
transaction.addMemo(undefined, 'России');
}, /^Error: MemoFormat must be valid ASCII$/);
});
@@ -1366,7 +1366,7 @@ describe('Transaction', function() {
it('Construct AccountSet transaction - invalid account', function() {
assert.throws(function() {
var transaction = new Transaction().accountSet('xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm');
new Transaction().accountSet('xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm');
});
});
@@ -1399,7 +1399,7 @@ describe('Transaction', function() {
it('Construct OfferCancel transaction - invalid account', function() {
assert.throws(function() {
var transaction = new Transaction().offerCancel('xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm', 1);
new Transaction().offerCancel('xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm', 1);
});
});
@@ -1601,7 +1601,7 @@ describe('Transaction', function() {
it('Construct Payment transaction - invalid account', function() {
assert.throws(function() {
var transaction = new Transaction().payment(
new Transaction().payment(
'xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm',
'r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe',
'1/USD/r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe'
@@ -1611,7 +1611,7 @@ describe('Transaction', function() {
it('Construct Payment transaction - invalid destination', function() {
assert.throws(function() {
var transaction = new Transaction().payment(
new Transaction().payment(
'rsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm',
'xr36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe',
'1/USD/r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe'
@@ -1680,7 +1680,7 @@ describe('Transaction', function() {
it('Construct TrustSet transaction - invalid account', function() {
assert.throws(function() {
var limit = '1/USD/r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe';
var transaction = new Transaction().trustSet('xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm', limit, 1.0, 1.0);
new Transaction().trustSet('xrsLEU1TPdCJPPysqhWYw9jD97xtG5WqSJm', limit, 1.0, 1.0);
});
});
@@ -1688,9 +1688,9 @@ describe('Transaction', function() {
var remote = new Remote();
var transaction = new Transaction(remote).accountSet('r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe');
assert.strictEqual(transaction.callback, void(0));
assert.strictEqual(transaction._errorHandler, void(0));
assert.strictEqual(transaction._successHandler, void(0));
assert.strictEqual(transaction.callback, undefined);
assert.strictEqual(transaction._errorHandler, undefined);
assert.strictEqual(transaction._successHandler, undefined);
assert.strictEqual(transaction.listeners('error').length, 1);
var account = remote.addAccount('r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWe');
@@ -1711,13 +1711,13 @@ describe('Transaction', function() {
receivedSuccess = true;
});
function submitCallback(err, res) {
function submitCallback(err) {
setImmediate(function() {
assert.ifError(err);
assert(receivedSuccess);
done();
});
};
}
transaction.submit(submitCallback);
@@ -1750,14 +1750,14 @@ describe('Transaction', function() {
receivedError = true;
});
function submitCallback(err, res) {
function submitCallback(err) {
setImmediate(function() {
assert(err);
assert.strictEqual(err.constructor.name, 'RippleError');
assert(receivedError);
done();
});
};
}
transaction.submit(submitCallback);
});
@@ -1777,7 +1777,7 @@ describe('Transaction', function() {
it('Submit transaction - invalid account', function(done) {
var remote = new Remote();
assert.throws(function() {
var transaction = new Transaction(remote).accountSet('r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWeZ');
new Transaction(remote).accountSet('r36xtKNKR43SeXnGn7kN4r4JdQzcrkqpWeZ');
});
done();
});
@@ -1787,7 +1787,9 @@ describe('Transaction', function() {
remote.setSecret('rJaT8TafQfYJqDm8aC5n3Yx5yWEL2Ery79', 'snPwFATthTkKnGjEW73q3TL4yci1Q');
var server = new Server(remote, 'wss://s1.ripple.com:443');
server._computeFee = function() { return '12'; };
server._computeFee = function() {
return '12';
};
server._connected = true;
remote._servers.push(server);
@@ -1803,7 +1805,7 @@ describe('Transaction', function() {
transaction.abort();
});
transaction.submit(function(err, res) {
transaction.submit(function(err) {
setImmediate(function() {
assert(err);
assert.strictEqual(err.result, 'tejAbort');
@@ -1845,5 +1847,3 @@ describe('Transaction', function() {
});
});
});
//vim:sw=2:sts=2:ts=8:et