ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-20 12:15:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

[BUG] Request.prototype.ledgerSelect can accept ledger_index as String

Browse Source
This commit is contained in:
Alan Cohen
2015-01-21 08:54:40 -08:00
parent 42e7932f59
commit 525ff9b75e
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/ripple/request.js
View File

@@ -355,8 +355,8 @@ Request.prototype.ledgerSelect = function(ledger) {
this.message.ledger_index = ledger;
break;
default:
if (typeof ledger === 'number' && isFinite(ledger)) {
this.message.ledger_index = ledger;
if (Number(ledger) && isFinite(Number(ledger))) {
this.message.ledger_index = Number(ledger);
} else if (/^[A-F0-9]{64}$/.test(ledger)) {
this.message.ledger_hash = ledger;
}

10
test/request-test.js
View File

@@ -726,6 +726,16 @@ describe('Request', function() {
assert.strictEqual(request.message.ledger_hash, void(0));
});
it('Select ledger - index (String)', function() {
var remote = new Remote();
remote._connected = true;
var request = new Request(remote, 'server_info');
request.ledgerSelect('7016915');
assert.strictEqual(request.message.ledger_index, 7016915);
assert.strictEqual(request.message.ledger_hash, void(0));
});
it('Select ledger - hash', function() {
var remote = new Remote();
remote._connected = true;