Do not return non-validated transaction from RippleAPI#getTransaction

src/api/ledger/transaction.js

@@ -57,6 +57,11 @@ function getTransactionAsync(identifier: string, options: TransactionOptions,
 
   function callbackWrapper(error_?: Error, tx?: Object) {
     let error = error_;
+
+    if (!error && tx && tx.validated !== true) {
+      return callback(new errors.NotFoundError('Transaction not found'));
+    }
+
     if (error instanceof RippleError && error.remote &&
       error.remote.error === 'txnNotFound') {
       error = new errors.NotFoundError('Transaction not found');

test/api-test.js

@@ -217,9 +217,11 @@ describe('RippleAPI', function() {
   it('getTransaction - not validated', function() {
     const hash =
       '4FB3ADF22F3C605E23FAEFAA185F3BD763C4692CAC490D9819D117CD33BFAA10';
-    return this.api.getTransaction(hash).then(
+    return this.api.getTransaction(hash).then(() => {
-      _.partial(checkResult, responses.getTransaction.notValidated,
+      assert(false, 'Should throw NotFoundError');
-      'getTransaction'));
+    }).catch(error => {
+      assert(error instanceof this.api.errors.NotFoundError);
+    });
   });
 
   it('getTransaction - tracking on', function() {

test/fixtures/api/rippled/tx/not-validated.json

@@ -40,6 +40,7 @@
       ],
       "TransactionIndex": 5,
       "TransactionResult": "tesSUCCESS"
-    }
+    },
+    "validated": false
   }
 }

test/fixtures/api/rippled/tx/payment.json

@@ -181,6 +181,7 @@
       ],
       "TransactionIndex": 0,
       "TransactionResult": "tesSUCCESS"
-    }
+    },
+    "validated": true
   }
 }