ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-21 12:45:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: rename DisallowIncoming flag for NFTs (#2235)

Browse Source 
`lsfDisallowIncomingNFTOffer` to `lsfDisallowIncomingNFTokenOffer`
`asfDisallowIncomingNFTOffer` to `asfDisallowIncomingNFTokenOffer`

Related to XRPLF/rippled#4442
This commit is contained in:
Caleb Kniffen
2023-03-08 11:52:18 -06:00
committed by GitHub
parent 2286d295bb
commit 3c2bfdf766
4 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/xrpl/HISTORY.md
View File

@@ -9,6 +9,7 @@ Subscribe to [the **xrpl-announce** mailing list](https://groups.google.com/g/xr
* Fix timeout error in request manager * Fix timeout error in request manager
* Improved typescript typing * Improved typescript typing
* Fixed empty value condition for NFTokenMinter field in AccountSet transaction * Fixed empty value condition for NFTokenMinter field in AccountSet transaction
* Renamed `lsfDisallowIncomingNFTOffer` and `asfDisallowIncomingNFTOffer` to `lsfDisallowIncomingNFTokenOffer` and `asfDisallowIncomingNFTokenOffer`
### Added ### Added
- `getNFTokenID` lets you get the NFTokenID after minting an NFT - `getNFTokenID` lets you get the NFTokenID after minting an NFT

4
packages/xrpl/src/models/ledger/AccountRoot.ts
View File

@@ -119,7 +119,7 @@ export interface AccountRootFlagsInterface {
/** /**
* Disallow incoming NFTOffers from other accounts. * Disallow incoming NFTOffers from other accounts.
*/ */
lsfDisallowIncomingNFTOffer?: boolean lsfDisallowIncomingNFTokenOffer?: boolean
/** /**
* Disallow incoming Checks from other accounts. * Disallow incoming Checks from other accounts.
*/ */
@@ -175,7 +175,7 @@ export enum AccountRootFlags {
/** /**
* Disallow incoming NFTOffers from other accounts. * Disallow incoming NFTOffers from other accounts.
*/ */
lsfDisallowIncomingNFTOffer = 0x04000000, lsfDisallowIncomingNFTokenOffer = 0x04000000,
/** /**
* Disallow incoming Checks from other accounts. * Disallow incoming Checks from other accounts.
*/ */

2
packages/xrpl/src/models/transactions/accountSet.ts
View File

@@ -49,7 +49,7 @@ export enum AccountSetAsfFlags {
asfAuthorizedNFTokenMinter = 10, asfAuthorizedNFTokenMinter = 10,
/** asf 11 is reserved for Hooks amendment */ /** asf 11 is reserved for Hooks amendment */
/** Disallow other accounts from creating incoming NFTOffers */ /** Disallow other accounts from creating incoming NFTOffers */
asfDisallowIncomingNFTOffer = 12, asfDisallowIncomingNFTokenOffer = 12,
/** Disallow other accounts from creating incoming Checks */ /** Disallow other accounts from creating incoming Checks */
asfDisallowIncomingCheck = 13, asfDisallowIncomingCheck = 13,
/** Disallow other accounts from creating incoming PayChannels */ /** Disallow other accounts from creating incoming PayChannels */

6
packages/xrpl/test/models/utils.test.ts
View File

@@ -163,7 +163,7 @@ describe('Models Utils', function () {
AccountRootFlags.lsfPasswordSpent | AccountRootFlags.lsfPasswordSpent |
AccountRootFlags.lsfRequireAuth | AccountRootFlags.lsfRequireAuth |
AccountRootFlags.lsfRequireDestTag | AccountRootFlags.lsfRequireDestTag |
AccountRootFlags.lsfDisallowIncomingNFTOffer | AccountRootFlags.lsfDisallowIncomingNFTokenOffer |
AccountRootFlags.lsfDisallowIncomingCheck | AccountRootFlags.lsfDisallowIncomingCheck |
AccountRootFlags.lsfDisallowIncomingPayChan | AccountRootFlags.lsfDisallowIncomingPayChan |
AccountRootFlags.lsfDisallowIncomingTrustline AccountRootFlags.lsfDisallowIncomingTrustline
@@ -180,7 +180,7 @@ describe('Models Utils', function () {
parsed.lsfPasswordSpent && parsed.lsfPasswordSpent &&
parsed.lsfRequireAuth && parsed.lsfRequireAuth &&
parsed.lsfRequireDestTag && parsed.lsfRequireDestTag &&
parsed.lsfDisallowIncomingNFTOffer && parsed.lsfDisallowIncomingNFTokenOffer &&
parsed.lsfDisallowIncomingCheck && parsed.lsfDisallowIncomingCheck &&
parsed.lsfDisallowIncomingPayChan && parsed.lsfDisallowIncomingPayChan &&
parsed.lsfDisallowIncomingTrustline, parsed.lsfDisallowIncomingTrustline,
@@ -199,7 +199,7 @@ describe('Models Utils', function () {
assert.isUndefined(parsed.lsfPasswordSpent) assert.isUndefined(parsed.lsfPasswordSpent)
assert.isUndefined(parsed.lsfRequireAuth) assert.isUndefined(parsed.lsfRequireAuth)
assert.isUndefined(parsed.lsfRequireDestTag) assert.isUndefined(parsed.lsfRequireDestTag)
assert.isUndefined(parsed.lsfDisallowIncomingNFTOffer) assert.isUndefined(parsed.lsfDisallowIncomingNFTokenOffer)
assert.isUndefined(parsed.lsfDisallowIncomingCheck) assert.isUndefined(parsed.lsfDisallowIncomingCheck)
assert.isUndefined(parsed.lsfDisallowIncomingPayChan) assert.isUndefined(parsed.lsfDisallowIncomingPayChan)
assert.isUndefined(parsed.lsfDisallowIncomingTrustline) assert.isUndefined(parsed.lsfDisallowIncomingTrustline)