fix: remove tx serialization check (#2293)

* remove tx serialization check

* clean up

* update changelog

* bring back some of the logic to check txs

* move memo logic to `validate`

* move other checks to `validate`

* fix tests

* update cspell
This commit is contained in:
Mayukha Vadari
2023-04-28 19:15:31 -04:00
committed by GitHub
parent 15e5eb552e
commit 2442ef1415
6 changed files with 64 additions and 146 deletions

View File

@@ -763,7 +763,7 @@ describe('Wallet', function () {
}
assert.throws(() => {
wallet.sign(payment)
}, /^Trying to sign an issued currency with a similar standard code to XRP \(received 'xrp'\)\. XRP is not an issued currency\./u)
}, /^Cannot have an issued currency with a similar standard code to XRP \(received 'xrp'\)\. XRP is not an issued currency\./u)
})
it('sign does NOT throw when a payment contains an issued currency like xrp in hex string format', async function () {