From 2422b9a30b94b25023f7944c50757e00cc7363d7 Mon Sep 17 00:00:00 2001 From: Chris Clark Date: Tue, 17 Nov 2015 11:30:26 -0800 Subject: [PATCH] Update README for RippleAPI --- README.md | 79 ++----------------- test/api-test.js | 6 +- test/fixtures/requests/index.js | 1 + .../requests/prepare-order-cancellation.json | 1 + 4 files changed, 12 insertions(+), 75 deletions(-) create mode 100644 test/fixtures/requests/prepare-order-cancellation.json diff --git a/README.md b/README.md index 606895be..d7da8677 100644 --- a/README.md +++ b/README.md @@ -13,88 +13,21 @@ A JavaScript API for interacting with Ripple in Node.js and the browser + Listen to events on the Ripple network (transaction, ledger, etc.) + Sign and submit transactions to the Ripple network -###In this file - -1. [Installation](#installation) -2. [Quick start](#quick-start) -3. [Running tests](#running-tests) - -###Additional documentation - -1. [Guides](docs/GUIDES.md) -2. [API Reference](docs/REFERENCE.md) -3. [Wiki](https://ripple.com/wiki/Ripple_JavaScript_library) - -###Also see - -+ [The Ripple wiki](https://ripple.com/wiki) -+ [ripple.com](https://ripple.com) - -##Installation - -**Via npm for Node.js** +##Getting Started +Install `ripple-lib` using npm: ``` $ npm install ripple-lib ``` -**Via bower (for browser use)** - -``` - $ bower install ripple -``` - -See the [bower-ripple repo](https://github.com/ripple/bower-ripple) for additional bower instructions. - - -**Building ripple-lib for browser environments** - -ripple-lib uses Gulp to generate browser builds. These steps will generate minified and non-minified builds of ripple-lib in the `build/` directory. - -``` - $ git clone https://github.com/ripple/ripple-lib - $ npm install - $ npm run build -``` - -**Restricted browser builds** - -You may generate browser builds that contain a subset of features. To do this, run `./node_modules/.bin/gulp build-` - -+ `build-core` Contains the functionality to make requests and listen for events such as `ledgerClose`. Only `ripple.Remote` is currently exposed. Advanced features like transaction submission and orderbook tracking are excluded from this build. - -##Quick start - -`Remote.js` ([remote.js](https://github.com/ripple/ripple-lib/blob/develop/src/js/ripple/remote.js)) is the point of entry for interacting with rippled - -```js -/* Loading ripple-lib with Node.js */ -var Remote = require('ripple-lib').Remote; - -/* Loading ripple-lib in a webpage */ -// var Remote = ripple.Remote; - -var remote = new Remote({ - // see the API Reference for available options - servers: [ 'wss://s1.ripple.com:443' ] -}); - -remote.connect(function() { - /* remote connected */ - remote.requestServerInfo(function(err, info) { - // process err and info - }); -}); -``` +Then see the sample code in `docs/samples`. ##Running tests 1. Clone the repository - 2. `cd` into the repository and install dependencies with `npm install` +3. `npm test` or `npm test --coverage` (`istanbul` will create coverage reports in coverage/lcov-report/`) -3. `npm test` +##More Information -**Generating code coverage** - -ripple-lib uses `istanbul` to generate code coverage. To create a code coverage report, run `npm test --coverage`. The report will be created in `coverage/lcov-report/`. ++ [Ripple Dev Portal](https://ripple.com/build/) diff --git a/test/api-test.js b/test/api-test.js index 82686003..23e74e31 100644 --- a/test/api-test.js +++ b/test/api-test.js @@ -91,8 +91,10 @@ describe('RippleAPI', function() { }); it('prepareOrderCancellation', function() { - return this.api.prepareOrderCancellation(address, 23, instructions).then( - _.partial(checkResult, responses.prepareOrderCancellation, 'prepare')); + const request = requests.prepareOrderCancellation; + return this.api.prepareOrderCancellation(address, request, instructions) + .then(_.partial(checkResult, responses.prepareOrderCancellation, + 'prepare')); }); it('prepareTrustline - simple', function() { diff --git a/test/fixtures/requests/index.js b/test/fixtures/requests/index.js index fc1cad68..7fe40078 100644 --- a/test/fixtures/requests/index.js +++ b/test/fixtures/requests/index.js @@ -6,6 +6,7 @@ module.exports = { sell: require('./prepare-order-sell'), expiration: require('./prepare-order-expiration') }, + prepareOrderCancellation: require('./prepare-order-cancellation'), preparePayment: require('./prepare-payment'), preparePaymentAllOptions: require('./prepare-payment-all-options'), preparePaymentNoCounterparty: require('./prepare-payment-no-counterparty'), diff --git a/test/fixtures/requests/prepare-order-cancellation.json b/test/fixtures/requests/prepare-order-cancellation.json new file mode 100644 index 00000000..40994076 --- /dev/null +++ b/test/fixtures/requests/prepare-order-cancellation.json @@ -0,0 +1 @@ +23