From 23528293e03c4c624b8b1aa141ac2d5fc1e6aac0 Mon Sep 17 00:00:00 2001
From: Nicholas Dudfield <ndudfield@gmail.com>
Date: Sat, 1 Feb 2014 10:46:04 +0700
Subject: [PATCH] Fix binary parsing of Vector256

---
 src/js/ripple/serializedtypes.js |  3 ++-
 test/serializedtypes-test.js     | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/js/ripple/serializedtypes.js b/src/js/ripple/serializedtypes.js
index c240b61d..663d6649 100644
--- a/src/js/ripple/serializedtypes.js
+++ b/src/js/ripple/serializedtypes.js
@@ -570,7 +570,8 @@ var STVector256 = exports.Vector256 = new SerializedType({
   parse: function (so) {
     var length = this.parse_varint(so);
     var output = [];
-    for (var i=0; i<length; i++) {
+    // length is number of bytes not number of Hash256
+    for (var i=0; i<length / 32; i++) {
       output.push(STHash256.parse(so));
     }
     return output;
diff --git a/test/serializedtypes-test.js b/test/serializedtypes-test.js
index a244b3d0..126c0d38 100644
--- a/test/serializedtypes-test.js
+++ b/test/serializedtypes-test.js
@@ -793,6 +793,21 @@ describe('Serialized types', function() {
   });
 
   describe('Object', function() {
+    it('Can parse objects with VL encoded Vector256', function() {
+      var hex = '110064220000000058000360186E008422E06B72D5B275E29EE3BE9D87A370F424E0E7BF613C4659098214289D19799C892637306AAAF03805EDFCDF6C28B8011320081342A0AB45459A54D8E4FA1842339A102680216CF9A152BCE4F4CE467D8246';
+      var so  = new SerializedObject(hex);
+      var as_json = so.to_json();
+      var expected_json = {
+        "LedgerEntryType": "DirectoryNode", 
+        "Owner": "rh6kN9s7spSb3vdv6H8ZGYzsddSLeEUGmc", 
+        "Flags": 0, 
+        "Indexes": [
+          "081342A0AB45459A54D8E4FA1842339A102680216CF9A152BCE4F4CE467D8246"
+        ], 
+        "RootIndex": "000360186E008422E06B72D5B275E29EE3BE9D87A370F424E0E7BF613C465909"
+      }
+      assert.deepEqual(as_json, expected_json);
+    });
     it('Serialize empty object {}', function () {
       var so = new SerializedObject();
       types.Object.serialize(so, {});