ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-13 09:05:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken test in connection.ts for node 18 and add node 18 testing (#2183)

Browse Source 
* Change localhost to 127.0.0.1

* Add Node 18 testing
This commit is contained in:
Jackson Mills
2023-01-09 09:26:14 -08:00
committed by GitHub
parent 8abcfe4640
commit 17f04b3083
2 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.github/workflows/nodejs.yml vendored
View File

@@ -5,7 +5,7 @@ name: Node.js CI
on: on:
push: push:
branches: [ main, 1.x ] branches: [main, 1.x]
pull_request: pull_request:
workflow_dispatch: workflow_dispatch:
@@ -57,7 +57,7 @@ jobs:
strategy: strategy:
matrix: matrix:
node-version: [12.x, 14.x, 16.x] node-version: [12.x, 14.x, 16.x, 18.x]
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
@@ -98,15 +98,14 @@ jobs:
strategy: strategy:
matrix: matrix:
node-version: [12.x, 14.x, 16.x] node-version: [12.x, 14.x, 16.x, 18.x]
services: services:
rippled: rippled:
image: natenichols/rippled-standalone:latest image: natenichols/rippled-standalone:latest
ports: ports:
- 6006:6006 - 6006:6006
options: options: --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
--health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
@@ -156,9 +155,8 @@ jobs:
rippled: rippled:
image: natenichols/rippled-standalone:latest image: natenichols/rippled-standalone:latest
ports: ports:
- 6006:6006 - 6006:6006
options: options: --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
--health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3

2
packages/xrpl/test/connection.test.ts
View File

@@ -136,7 +136,7 @@ describe('Connection', function () {
createServer().then((server: net.Server) => { createServer().then((server: net.Server) => {
const port = (server.address() as net.AddressInfo).port const port = (server.address() as net.AddressInfo).port
const options = { const options = {
proxy: `ws://localhost:${port}`, proxy: `ws://127.0.0.1:${port}`,
authorization: 'authorization', authorization: 'authorization',
trustedCertificates: ['path/to/pem'], trustedCertificates: ['path/to/pem'],
} }