ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2025-11-27 23:55:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

in isValidAddress check that address starting with 'r'

Browse Source 
because UInt160 considers valid hex values
This commit is contained in:
Ivan Tivonenko
2015-08-19 04:57:27 +03:00
parent 2515d17a85
commit 0e97f269ab
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/api/common/schema-validator.js
View File

@@ -12,7 +12,9 @@ const ValidationError = require('./errors').ValidationError;
let SCHEMAS = {}; let SCHEMAS = {};
function isValidAddress(address: string): boolean { function isValidAddress(address: string): boolean {
return core.UInt160.is_valid(address); return typeof address === 'string' && address.length > 0 &&
address[0] === 'r' &&
core.UInt160.is_valid(address);
} }
function isValidLedgerHash(ledgerHash) { function isValidLedgerHash(ledgerHash) {

7
test/api-test.js
View File

@@ -803,4 +803,11 @@ describe('RippleAPI - offline', function() {
const api = new RippleAPI(); const api = new RippleAPI();
assert(!api.isValidAddress(address.slice(0, -1) + 'a')); assert(!api.isValidAddress(address.slice(0, -1) + 'a'));
}); });
it('isValidAddress - invalid - hex representation', function() {
const api = new RippleAPI();
const hex = '6e3efa86a5eb0a3c5dc9beb3a204783bb00e1913';
assert(!api.isValidAddress(hex));
});
}); });