From 02fd0ce323f43ddf2a144c8fc05e1444e34b3c2d Mon Sep 17 00:00:00 2001
From: Nathan Nichols <natenichols@cox.net>
Date: Tue, 28 Sep 2021 16:42:05 -0700
Subject: [PATCH] refactor: clean up getFaucetWallet starting balance (#1677)

---
 src/wallet/generateFaucetWallet.ts | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/wallet/generateFaucetWallet.ts b/src/wallet/generateFaucetWallet.ts
index 7d3d9007..4f084b30 100644
--- a/src/wallet/generateFaucetWallet.ts
+++ b/src/wallet/generateFaucetWallet.ts
@@ -53,23 +53,16 @@ async function generateFaucetWallet(
       destination: fundWallet.classicAddress,
     }),
   )
-  // Retrieve the existing account balance
-  let addressToFundBalance: undefined | string
+
+  let startingBalance = 0
   try {
-    addressToFundBalance = await getAddressXrpBalance(
-      this,
-      fundWallet.classicAddress,
+    startingBalance = Number(
+      await getAddressXrpBalance(this, fundWallet.classicAddress),
     )
   } catch {
-    /* addressToFundBalance remains undefined */
+    /* startingBalance remains '0' */
   }
 
-  // Check the address balance is not undefined and is a number
-  const startingBalance =
-    addressToFundBalance && !Number.isNaN(Number(addressToFundBalance))
-      ? Number(addressToFundBalance)
-      : 0
-
   // Options to pass to https.request
   const options = getOptions(this, postBody)