Files
rippled/src/ripple/app/misc/FeeVoteImpl.cpp
Edward Hennis e3b5b808c5 Add units to all fee calculations:
* Uses existing XRPAmount with units for drops, and a new TaggedFee for
  fee units (LoadFeeTrack), and fee levels (TxQ).
* Resolves #2451
2020-01-08 18:44:01 -05:00

291 lines
8.5 KiB
C++

//------------------------------------------------------------------------------
/*
This file is part of rippled: https://github.com/ripple/rippled
Copyright (c) 2012, 2013 Ripple Labs Inc.
Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
//==============================================================================
#include <ripple/protocol/st.h>
#include <ripple/app/misc/FeeVote.h>
#include <ripple/app/main/Application.h>
#include <ripple/protocol/STValidation.h>
#include <ripple/basics/BasicConfig.h>
#include <ripple/beast/utility/Journal.h>
namespace ripple {
namespace detail {
class VotableValue
{
private:
using value_type = XRPAmount;
value_type const mCurrent; // The current setting
value_type const mTarget; // The setting we want
std::map <value_type, int> mVoteMap;
public:
VotableValue (value_type current, value_type target)
: mCurrent (current)
, mTarget (target)
{
// Add our vote
++mVoteMap[mTarget];
}
void
addVote(value_type vote)
{
++mVoteMap[vote];
}
void
noVote()
{
addVote (mCurrent);
}
value_type
getVotes() const;
};
auto
VotableValue::getVotes() const
-> value_type
{
value_type ourVote = mCurrent;
int weight = 0;
for (auto const& [key, val] : mVoteMap)
{
// Take most voted value between current and target, inclusive
if ((key <= std::max (mTarget, mCurrent)) &&
(key >= std::min (mTarget, mCurrent)) &&
(val > weight))
{
ourVote = key;
weight = val;
}
}
return ourVote;
}
}
//------------------------------------------------------------------------------
class FeeVoteImpl : public FeeVote
{
private:
Setup target_;
beast::Journal const journal_;
public:
FeeVoteImpl (Setup const& setup, beast::Journal journal);
void
doValidation (std::shared_ptr<ReadView const> const& lastClosedLedger,
STValidation::FeeSettings& fees) override;
void
doVoting (std::shared_ptr<ReadView const> const& lastClosedLedger,
std::vector<STValidation::pointer> const& parentValidations,
std::shared_ptr<SHAMap> const& initialPosition) override;
};
//--------------------------------------------------------------------------
FeeVoteImpl::FeeVoteImpl (Setup const& setup, beast::Journal journal)
: target_ (setup)
, journal_ (journal)
{
}
void
FeeVoteImpl::doValidation(
std::shared_ptr<ReadView const> const& lastClosedLedger,
STValidation::FeeSettings& fees)
{
if (lastClosedLedger->fees().base != target_.reference_fee)
{
JLOG(journal_.info()) <<
"Voting for base fee of " << target_.reference_fee;
fees.baseFee = target_.reference_fee;
}
if (lastClosedLedger->fees().accountReserve(0) != target_.account_reserve)
{
JLOG(journal_.info()) <<
"Voting for base reserve of " << target_.account_reserve;
fees.reserveBase = target_.account_reserve;
}
if (lastClosedLedger->fees().increment != target_.owner_reserve)
{
JLOG(journal_.info()) <<
"Voting for reserve increment of " << target_.owner_reserve;
fees.reserveIncrement = target_.owner_reserve;
}
}
void
FeeVoteImpl::doVoting(
std::shared_ptr<ReadView const> const& lastClosedLedger,
std::vector<STValidation::pointer> const& set,
std::shared_ptr<SHAMap> const& initialPosition)
{
// LCL must be flag ledger
assert ((lastClosedLedger->info().seq % 256) == 0);
detail::VotableValue baseFeeVote (
lastClosedLedger->fees().base,
target_.reference_fee);
detail::VotableValue baseReserveVote(
lastClosedLedger->fees().accountReserve(0),
target_.account_reserve);
detail::VotableValue incReserveVote (
lastClosedLedger->fees().increment,
target_.owner_reserve);
for (auto const& val : set)
{
if (val->isTrusted ())
{
if (val->isFieldPresent (sfBaseFee))
{
using xrptype = XRPAmount::value_type;
auto const vote = val->getFieldU64 (sfBaseFee);
if (vote <= std::numeric_limits<xrptype>::max() &&
isLegalAmount(XRPAmount{unsafe_cast<xrptype>(vote)}))
baseFeeVote.addVote(XRPAmount{
unsafe_cast<XRPAmount::value_type>(vote)});
else
// Invalid amounts will be treated as if they're
// not provided. Don't throw because this value is
// provided by an external entity.
baseFeeVote.noVote();
}
else
{
baseFeeVote.noVote ();
}
if (val->isFieldPresent (sfReserveBase))
{
baseReserveVote.addVote(XRPAmount{
val->getFieldU32(sfReserveBase)});
}
else
{
baseReserveVote.noVote ();
}
if (val->isFieldPresent (sfReserveIncrement))
{
incReserveVote.addVote (XRPAmount{
val->getFieldU32 (sfReserveIncrement)});
}
else
{
incReserveVote.noVote ();
}
}
}
// choose our positions
// If any of the values are invalid, send the current values.
auto const baseFee = baseFeeVote.getVotes ().dropsAs<std::uint64_t>(
lastClosedLedger->fees().base);
auto const baseReserve = baseReserveVote.getVotes ().dropsAs<std::uint32_t>(
lastClosedLedger->fees().accountReserve(0));
auto const incReserve = incReserveVote.getVotes ().dropsAs<std::uint32_t>(
lastClosedLedger->fees().increment);
constexpr FeeUnit32 feeUnits = Setup::reference_fee_units;
auto const seq = lastClosedLedger->info().seq + 1;
// add transactions to our position
if ((baseFee != lastClosedLedger->fees().base) ||
(baseReserve != lastClosedLedger->fees().accountReserve(0)) ||
(incReserve != lastClosedLedger->fees().increment))
{
JLOG(journal_.warn()) <<
"We are voting for a fee change: " << baseFee <<
"/" << baseReserve <<
"/" << incReserve;
STTx feeTx (ttFEE,
[seq,baseFee,baseReserve,incReserve,feeUnits](auto& obj)
{
obj[sfAccount] = AccountID();
obj[sfLedgerSequence] = seq;
obj[sfBaseFee] = baseFee;
obj[sfReserveBase] = baseReserve;
obj[sfReserveIncrement] = incReserve;
obj[sfReferenceFeeUnits] = feeUnits.fee();
});
uint256 txID = feeTx.getTransactionID ();
JLOG(journal_.warn()) <<
"Vote: " << txID;
Serializer s;
feeTx.add (s);
auto tItem = std::make_shared<SHAMapItem> (txID, s.peekData ());
if (!initialPosition->addGiveItem (tItem, true, false))
{
JLOG(journal_.warn()) <<
"Ledger already had fee change";
}
}
}
//------------------------------------------------------------------------------
FeeVote::Setup
setup_FeeVote (Section const& section)
{
FeeVote::Setup setup;
{
std::uint64_t temp;
if (set(temp, "reference_fee", section) &&
temp <= std::numeric_limits<XRPAmount::value_type>::max())
setup.reference_fee = temp;
}
{
std::uint32_t temp;
if (set(temp, "account_reserve", section))
setup.account_reserve = temp;
if (set(temp, "owner_reserve", section))
setup.owner_reserve = temp;
}
return setup;
}
std::unique_ptr<FeeVote>
make_FeeVote (FeeVote::Setup const& setup, beast::Journal journal)
{
return std::make_unique<FeeVoteImpl> (setup, journal);
}
} // ripple