mirror of
https://github.com/XRPLF/rippled.git
synced 2026-09-26 23:19:07 +00:00
d687903c3f
Harness and docs: - integration-test.sh queried traces_span_metrics_* for spanmetrics, but this branch sets the connector namespace to "span", so those two checks matched nothing and failed. The dashboards and runbook had moved; the script had not. - The same script queried eight native metric names with a product prefix and capitals that formatName() cannot produce: it lowercases, maps '.' and ' ' to '_', and prepends nothing. Corrected against the runbook tables. - TESTING.md carried the same stale spanmetrics names and a jq example reading a Prometheus label that does not exist. - The runbook now records where each part of a derived metric name comes from, since only the namespace is ours to choose. Collector: - OTelCounterImpl::increment silently dropped a negative amount. An OTel counter takes unsigned deltas, so assert and let a release build under-count rather than wrap. - OTelGaugeImpl::increment computed current + amount in int64, which is undefined on overflow, and the clamp ran afterwards so it could not help. Check the headroom first. set() now clamps rather than casting a uint64 above INT64_MAX to a negative, which is what made underflow reachable. - The meter scope was two bare literals. They are constants now, and Telemetry.cpp static_asserts them equal to kMeterName and kMeterVersion: beast cannot include the telemetry header, so a build failure is the only way to catch the copies drifting. - formatName uses views::transform and ranges::to, as Backend.cpp already does. - Unused constructor parameters take [[maybe_unused]] instead of (void) casts. - The destructor logged "shutting down" and "stopped" with nothing between. initMetrics was 79 lines doing four jobs. The exporter and the histogram views are separate functions now, addUnitView is a member rather than a lambda capturing this, and the export interval and timeout are named. It also derived the metrics URL from the traces URL by suffix swap, which sent metrics to the traces path whenever the configured URL had any other shape; both URLs now come from one rule that handles a bare host, a trailing slash and either signal path.