mirror of
https://github.com/XRPLF/rippled.git
synced 2026-09-27 07:26:51 +00:00
623e3d8ad3
Review feedback asked for a Histogram rather than a span attribute at these two places. Both, not either: the attribute answers how big one sampled request was, which an aggregate cannot, and the histogram answers the distribution across all requests, which an unsampled trace never reveals. Both attributes stay. The metrics land here rather than with the attributes because neither HistogramBuckets.h nor the metric macro exists on the branch that added them. Both use kObjectCountBuckets. The argument is the floor, not the ceiling: the SDK default edges start 0,5,10,25, so an ordinary batch of one to five falls in a single bucket and every quantile becomes an interpolation on one edge. The object ladder puts five edges over the mass of both distributions. Path count is bounded at 352 by kMaxPaths times kMaxAutoSrcCur and cannot saturate. Batch size can, at roughly 333k, but no measured traffic goes near it, so the ladder is not widened for a range nothing occupies; the runbook records the overflow query and a test asserts it stays readable.