Pratik Mankawde c9521b97fe refactor(telemetry): pull consensus-tracing scope-leak out of phase-3 ...

Commit c6c019ed8b ("addressed code review comments") bundled tx-tracing
review fixes with consensus-tracing scaffolding that belongs on
pratik/otel-phase4-consensus-tracing (PR #6426). This commit lifts the
consensus-only parts back out of phase-3 so PR #6425 stays scoped to
transaction tracing. Phase-4 already carries the same content (via prior
phase-3 -> phase-4 merges) plus its own evolution on top, so nothing is
moved across — only removed here.

Removed:
  - src/xrpld/app/consensus/ConsensusSpanNames.h (deleted; phase-4 owns
    it).
  - PeerImp.cpp: revert onMessage(TMProposeSet)/onMessage(TMValidation)
    consensus-attr setAttribute calls to the hardcoded
    "xrpl.consensus.{trusted,round,ledger.seq}" strings used before
    c6c019ed8b. Drop the now-unused
    #include <xrpld/app/consensus/ConsensusSpanNames.h>.
  - RCLConsensus::Adaptor::validate(): remove the
    TODO(observability/secure-OTel) block on validation trace_context.
  - TraceContextPropagator.h: remove the TODO(observability/secure-OTel)
    block on injectToProtobuf().

Tx-tracing parts of c6c019ed8b are intentionally untouched.

No phase-3 caller of telemetry::consensus_span:: remains; verified via
git grep. No test on phase-3 references the removed header.

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

2026-05-28 16:51:23 +01:00

..

DiscardFlag.h

feat(telemetry): add FilteringSpanProcessor and SpanGuard::discard()

2026-04-28 14:25:31 +01:00

SpanGuard.h

addressed code review comments

2026-05-28 15:55:25 +01:00

SpanNames.h

addressed code review comments

2026-05-28 15:55:25 +01:00

Telemetry.h

addressed code review comments.

2026-05-27 17:36:06 +01:00

TraceContextPropagator.h

refactor(telemetry): pull consensus-tracing scope-leak out of phase-3

2026-05-28 16:51:23 +01:00