mirror of
https://github.com/XRPLF/rippled.git
synced 2025-12-06 17:27:55 +00:00
This is a substantial refactor of the consensus code and also introduces a basic consensus simulation and testing framework. The new generic/templated version is in src/ripple/consensus and documents the current type requirements. The version adapted for the RCL is in src/ripple/app/consensus. The testing framework is in src/test/csf. Minor behavioral changes/fixes include: * Adjust close time offset even when not validating. * Remove spurious proposing_ = false call at end of handleLCL. * Remove unused functionality provided by checkLastValidation. * Separate open and converge time * Don't send a bow out if we're not proposing * Prevent consensus stopping if NetworkOPs switches to disconnect mode while consensus accepts a ledger * Prevent a corner case in which Consensus::gotTxSet or Consensus::peerProposal has the potential to update internal state while an dispatched accept job is running. * Distinguish external and internal calls to startNewRound. Only external calls can reset the proposing_ state of consensus
164 lines
6.0 KiB
C++
164 lines
6.0 KiB
C++
//------------------------------------------------------------------------------
|
|
/*
|
|
This file is part of rippled: https://github.com/ripple/rippled
|
|
Copyright (c) 2012-2016 Ripple Labs Inc.
|
|
|
|
Permission to use, copy, modify, and/or distribute this software for any
|
|
purpose with or without fee is hereby granted, provided that the above
|
|
copyright notice and this permission notice appear in all copies.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
//==============================================================================
|
|
#include <BeastConfig.h>
|
|
#include <ripple/beast/unit_test.h>
|
|
#include <ripple/consensus/LedgerTiming.h>
|
|
|
|
namespace ripple {
|
|
namespace test {
|
|
|
|
class LedgerTiming_test : public beast::unit_test::suite
|
|
{
|
|
beast::Journal j;
|
|
|
|
void testGetNextLedgerTimeResolution()
|
|
{
|
|
// helper to iteratively call into getNextLedgerTimeResolution
|
|
struct test_res
|
|
{
|
|
std::uint32_t decrease = 0;
|
|
std::uint32_t equal = 0;
|
|
std::uint32_t increase = 0;
|
|
|
|
static test_res run(bool previousAgree, std::uint32_t rounds)
|
|
{
|
|
test_res res;
|
|
auto closeResolution = ledgerDefaultTimeResolution;
|
|
auto nextCloseResolution = closeResolution;
|
|
std::uint32_t round = 0;
|
|
do
|
|
{
|
|
nextCloseResolution = getNextLedgerTimeResolution(
|
|
closeResolution, previousAgree, ++round);
|
|
if (nextCloseResolution < closeResolution)
|
|
++res.decrease;
|
|
else if (nextCloseResolution > closeResolution)
|
|
++res.increase;
|
|
else
|
|
++res.equal;
|
|
std::swap(nextCloseResolution, closeResolution);
|
|
} while (round < rounds);
|
|
return res;
|
|
}
|
|
};
|
|
|
|
|
|
// If we never agree on close time, only can increase resolution
|
|
// until hit the max
|
|
auto decreases = test_res::run(false, 10);
|
|
BEAST_EXPECT(decreases.increase == 3);
|
|
BEAST_EXPECT(decreases.decrease == 0);
|
|
BEAST_EXPECT(decreases.equal == 7);
|
|
|
|
// If we always agree on close time, only can decrease resolution
|
|
// until hit the min
|
|
auto increases = test_res::run(false, 100);
|
|
BEAST_EXPECT(increases.increase == 3);
|
|
BEAST_EXPECT(increases.decrease == 0);
|
|
BEAST_EXPECT(increases.equal == 97);
|
|
|
|
}
|
|
|
|
void testRoundCloseTime()
|
|
{
|
|
// A closeTime equal to the epoch is not modified
|
|
using tp = NetClock::time_point;
|
|
tp def;
|
|
BEAST_EXPECT(def == roundCloseTime(def, 30s));
|
|
|
|
// Otherwise, the closeTime is rounded to the nearest
|
|
// rounding up on ties
|
|
BEAST_EXPECT(tp{ 0s } == roundCloseTime(tp{ 29s }, 60s));
|
|
BEAST_EXPECT(tp{ 30s } == roundCloseTime(tp{ 30s }, 1s));
|
|
BEAST_EXPECT(tp{ 60s } == roundCloseTime(tp{ 31s }, 60s));
|
|
BEAST_EXPECT(tp{ 60s } == roundCloseTime(tp{ 30s }, 60s));
|
|
BEAST_EXPECT(tp{ 60s } == roundCloseTime(tp{ 59s }, 60s));
|
|
BEAST_EXPECT(tp{ 60s } == roundCloseTime(tp{ 60s }, 60s));
|
|
BEAST_EXPECT(tp{ 60s } == roundCloseTime(tp{ 61s }, 60s));
|
|
|
|
}
|
|
|
|
void testShouldCloseLedger()
|
|
{
|
|
// Bizarre times forcibly close
|
|
BEAST_EXPECT(shouldCloseLedger(true, 10, 10, 10, -10s, 10s, 1s, 1s, j));
|
|
BEAST_EXPECT(shouldCloseLedger(true, 10, 10, 10, 100h, 10s, 1s, 1s, j));
|
|
BEAST_EXPECT(shouldCloseLedger(true, 10, 10, 10, 10s, 100h, 1s, 1s, j));
|
|
|
|
// Rest of network has closed
|
|
BEAST_EXPECT(shouldCloseLedger(true, 10, 3, 5, 10s, 10s, 10s, 10s, j));
|
|
|
|
// No transactions means wait until end of internval
|
|
BEAST_EXPECT(!shouldCloseLedger(false, 10, 0, 0, 1s, 1s, 1s, 10s, j));
|
|
BEAST_EXPECT(shouldCloseLedger(false, 10, 0, 0, 1s, 10s, 1s, 10s, j));
|
|
|
|
// Enforce minimum ledger open time
|
|
BEAST_EXPECT(!shouldCloseLedger(true, 10, 0, 0, 10s, 10s, 1s, 10s, j));
|
|
|
|
// Don't go too much faster than last time
|
|
BEAST_EXPECT(!shouldCloseLedger(true, 10, 0, 0, 10s, 10s, 3s, 10s, j));
|
|
|
|
BEAST_EXPECT(shouldCloseLedger(true, 10, 0, 0, 10s, 10s, 10s, 10s, j));
|
|
|
|
}
|
|
|
|
void testCheckConsensus()
|
|
{
|
|
// Not enough time has elapsed
|
|
BEAST_EXPECT( ConsensusState::No
|
|
== checkConsensus(10, 2, 2, 0, 3s, 2s, true, j));
|
|
|
|
// If not enough peers have propsed, ensure
|
|
// more time for proposals
|
|
BEAST_EXPECT( ConsensusState::No
|
|
== checkConsensus(10, 2, 2, 0, 3s, 4s, true, j));
|
|
|
|
// Enough time has elapsed and we all agree
|
|
BEAST_EXPECT( ConsensusState::Yes
|
|
== checkConsensus(10, 2, 2, 0, 3s, 10s, true, j));
|
|
|
|
// Enough time has elapsed and we don't yet agree
|
|
BEAST_EXPECT( ConsensusState::No
|
|
== checkConsensus(10, 2, 1, 0, 3s, 10s, true, j));
|
|
|
|
// Our peers have moved on
|
|
// Enough time has elapsed and we all agree
|
|
BEAST_EXPECT( ConsensusState::MovedOn
|
|
== checkConsensus(10, 2, 1, 8, 3s, 10s, true, j));
|
|
|
|
// No peers makes it easy to agree
|
|
BEAST_EXPECT( ConsensusState::Yes
|
|
== checkConsensus(0, 0, 0, 0, 3s, 10s, true, j));
|
|
|
|
}
|
|
|
|
void
|
|
run() override
|
|
{
|
|
testGetNextLedgerTimeResolution();
|
|
testRoundCloseTime();
|
|
testShouldCloseLedger();
|
|
testCheckConsensus();
|
|
}
|
|
|
|
};
|
|
|
|
BEAST_DEFINE_TESTSUITE(LedgerTiming, consensus, ripple);
|
|
} // test
|
|
} // ripple
|