mirror of
https://github.com/XRPLF/rippled.git
synced 2026-09-27 15:28:03 +00:00
44d1994d6a
Review follow-up on the freshen lock-hold fix: - Drop host names, dates and one-site figures from the new comments, harness notes and docs; explain the mechanism in general terms. - RotationPhase stores its stage and cache labels as owned std::string, not std::string_view: the ctor still takes views so the label constants pass without a copy, but a member view would dangle if a caller ever passed a temporary. freshenCache/recordFreshen take the cache name by std::string_view (read-only, call-scoped). - The new DatabaseRotating test called fetchNodeObject through the derived type, whose private override hides the public base method; call it through Database& instead. This was the dev-box build break. - freshenCache reports the exact fetched count when a health abort cuts it short, and stops labelling the per-partition hold 'getKeys'. - Remove a [[maybe_unused]] that silenced no warning (the build sets -Wno-unused-parameter and disables misc-unused-parameters).