mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-21 22:30:57 +00:00
ac71480a62
The transitions panel used increase(...[$__rate_interval]). $__rate_interval is defined as max($__interval + scrape, 4 * scrape), i.e. deliberately one scrape longer than the step so rate() windows overlap and lose no counter increase. That overlap is harmless for rate(), but this panel reads the value as a count of discrete events, and the overlap counts each event in more than one bucket. Measured against a log-derived ground truth of 106 syncing transitions on devnet-otel-usw2-01 over 2026-08-11T11:05Z..2026-08-12T23:04Z, the old query reported 111.3 at a 300s step and 133.7 at a 60s step -- the error grew to +26% as you zoomed in, because the overlap is a larger fraction of a smaller step. Switch to $__interval so the buckets tile exactly, and wrap in round() because increase() extrapolates to the window edges and so reports fractional counts for an integer counter. The same measurement now gives 106 at 300s, 105 at 60s and 107 at 900s. Every state and both nodes land within a few counts of truth at any zoom, and the legend Total is now a meaningful figure. Pin Min step to 1m: the real scrape interval is 60s while the datasource declares 15s, so without a floor $__interval can fall below one sample. Draw as bars with 0 decimals -- the value is a discrete count per bucket, and a line implies interpolation between counts that does not exist.