Pratik Mankawde 9d71dea972 refactor(telemetry): mark the telemetry accessors nodiscard ...

getInstance(), getTracer(), both startSpan() overloads and networkTypeFromId()
return values that a caller must use. A discarded startSpan() result destroys
the returned span immediately, so the span opens and closes with no content.

Six methods in Telemetry.h already carried the attribute, on the base and on
every override. The new attributes follow that: the overrides in Telemetry.cpp
and NullTelemetry.cpp get it too, because [[nodiscard]] is not inherited and a
call bound to the derived type would otherwise be unchecked.

No caller anywhere in the chain discards any of these results.

2026-09-03 15:00:28 +01:00

..

xrpl

refactor(telemetry): mark the telemetry accessors nodiscard

2026-09-03 15:00:28 +01:00