mirror of
https://github.com/XRPLF/rippled.git
synced 2026-09-27 07:26:51 +00:00
9aebdc292c
Review feedback on the plan documents. Four kinds of error: - Symbols that do not exist: ConsensusProposal::prevLedger_ (it is previousLedger_), RCLConsensusAdaptor (it is RCLConsensus::Adaptor, and startRound() is on RCLConsensus itself), and RPCHandler::doCommand (a free function, xrpl::rpc::doCommand). - Attribute keys: the tables used ledger_index, which no telemetry code emits. Same concept as ledger_seq but a different referent, so the code disambiguates by prefix: current_ledger_seq for the open ledger a transaction targeted, ledger_seq for a closed or validated one. A note now states which is which. - TraceQL that does not parse: span-field predicates need braces, status.code is not an intrinsic (status = error), and avg(duration) does not take a by clause (avg_over_time does). All five re-tested against Tempo. - The StatsD comparison omitted the Histogram instrument, which aggregates at the point of measure, and the when-to-use table had no row for a metric that spans cannot afford to carry.