mirror of
https://github.com/XRPLF/rippled.git
synced 2026-09-28 15:58:07 +00:00
CI's clang-tidy job failed on this branch. clang-tidy itself succeeded; the step that failed was the gate that fails the job when findings exist, and the uploaded diff named exactly two missing includes. Event.h calls notify(std::uint64_t) but never included <cstdint>, relying on it arriving transitively. This is pre-existing on the branch rather than new, surfaced now because clang-tidy only inspects changed files and this one has not been touched since. InboundTransactions.cpp uses uint256 throughout and had no direct include for it either. The round-request work added further direct uses, which is what brought the file into clang-tidy's changed-file set. Both fixes are the ones clang-tidy generated itself, applied with the repo's angle-bracket include style; the include-style and clang-format hooks accept the placement unchanged. Note on why this was not caught before pushing: TIDY=1 clang-tidy was run locally and passed, but against the compile database under ~/sourceCode/.clangdcache/<worktree>/, which was stale -- generated before these edits. A stale database makes a local clang-tidy pass meaningless, as project-map.md warns. CI holds the only current one.