Pratik Mankawde 90bc58a658 refactor(telemetry): use ranges algorithms in ValidationTracker, mark accessors nodiscard ...

Nine std::count_if calls over window1h_ and window7d_ took an iterator
pair; std::ranges::count_if takes the container. One hand-rolled
erase-while-iterating loop becomes a single std::erase_if: pending_ is a
hash_map, which is a std::unordered_map alias, so the C++20 overload applies.

The hard-trim loop below it is left as a loop on purpose. It re-tests
pending_.size() every step to stop as soon as the cap is met, which erase_if
cannot express.

The accessors return values a caller must use: 13 in ValidationTracker.h, the
two Unit.h mappers, the two HistogramBuckets.h helpers, getMeter() and
networkTypeFromId(). No caller in the chain discards any of them.

2026-09-03 15:01:21 +01:00

..

xrpl

refactor(telemetry): use ranges algorithms in ValidationTracker, mark accessors nodiscard

2026-09-03 15:01:21 +01:00