8192da5243
Add two GTests on the SpanGuardScopeTest fixture and install a
CoroAwareContextStorage so the tests exercise coro-aware ambient context:
- scopedGuard_survives_localvalue_store_swap: a ScopedSpanGuard's scope
is hidden when its LocalValue store is swapped out and visible again
when swapped back in, and pops cleanly under the owning store.
- activate_sets_ambient_without_owning: SpanGuard::activate() makes the
span ambient for the activation's lifetime without ending it; the
owning guard ends it exactly once.
Fix the cross-store death test to match the store-identity assertion
message ("constructing context store", not "constructing thread") after
the A3 refactor; the fixture's storage install is what lets the assert
fire at all.
Revert RipplePathFind's pathfind.request from freshRoot SpanGuard back to
ScopedSpanGuard: the coro-aware storage moves the scope with the
coroutine across yield, so it nests under rpc.command and stays
trace-correlated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
How to use RPC coroutines.
Introduction.
By default, an RPC handler runs as an uninterrupted task on the JobQueue. This is fine for commands that are fast to compute but might not be acceptable for tasks that require multiple parts or are large, like a full ledger.
For this purpose, the xrpld RPC handler allows suspension with continuation
- a request to suspend execution of the RPC response and to continue it after some function or job has been executed. A default continuation is supplied which simply reschedules the job on the JobQueue, or the programmer can supply their own.
The classes.
Suspension with continuation uses four std::functions in the xrpl::RPC
namespace:
using Callback = std::function <void ()>;
using Continuation = std::function <void (Callback const&)>;
using Suspend = std::function <void (Continuation const&)>;
using Coroutine = std::function <void (Suspend const&)>;
A Callback is a generic 0-argument function. A given Callback might or might
not block. Unless otherwise advised, do not hold locks or any resource that
would prevent any other task from making forward progress when you call a
Callback.
A Continuation is a function that is given a Callback and promises to call
it later. A Continuation guarantees to call the Callback exactly once at
some point in the future, but it does not have to be immediately or even in the
current thread.
A Suspend is a function belonging to a Coroutine. A Suspend runs a
Continuation, passing it a Callback that continues execution of the
Coroutine.
And finally, a Coroutine is a std::function which is given a
Suspend. This is what the RPC handler gives to the coroutine manager,
expecting to get called back with a Suspend and to be able to start execution.
The flow of control.
Given these functions, the flow of RPC control when using coroutines is straight-forward.
-
The instance of
ServerHandlerreceives an RPC request. -
It creates a
Coroutineand gives it to the coroutine manager. -
The coroutine manager creates a
Coroutine, starts it up, and then calls theCoroutinewith aSuspend. -
Now the RPC response starts to be calculated.
-
When the RPC handler wants to suspend, it calls the
Suspendfunction with aContinuation. -
Coroutine execution is suspended.
-
The
Continuationis called with aCallbackthat the coroutine manager creates. -
The
Continuationmay choose to execute immediately, defer execution on the job queue, or wait for some resource to be free. -
When the
Continuationis finished, it calls theCallbackthat the coroutine manager gave it, perhaps a long time ago. -
This
Callbackcontinues execution on the suspendedCoroutinefrom where it left off.