Pratik Mankawde 6aa59629de fix(tests): make the fetch-duration assertions machine-independent ...

BEAST_EXPECT(getFetchDurationUs() > 0) failed on the macOS arm64 runner at
DatabaseConfig_test.cpp:879. It is an assertion about the host, not the
code: Database::fetchNodeObject() truncates each fetch to whole
microseconds, and a read served from NuDB's in-memory buckets can
genuinely measure under one microsecond. On a host fast enough for every
read to truncate, the total legitimately stays at zero.

Both fetch-duration checks now compare the accumulator against the total
the scheduler's fetch reports carried, via a CountingScheduler. Each
fetch is measured once and that one value feeds both, so the equality
holds at any host speed while being strictly stronger than '> 0': a
dropped fetch, a double-count, or the write member being returned all
break it. The same reasoning is already recorded in the GTest at
src/tests/libxrpl/nodestore/Database.cpp.

The store-duration '> 0' checks are left alone: those writes reach disk
and were not what failed.

2026-07-28 17:43:59 +01:00

..

DatabaseConfig_test.cpp

fix(tests): make the fetch-duration assertions machine-independent

2026-07-28 17:43:59 +01:00

import_test.cpp

test: Migrate nodestore tests from Beast to GTest (#7292)

2026-07-27 13:00:14 +00:00