mirror of
https://github.com/XRPLF/rippled.git
synced 2026-10-11 06:08:02 +00:00
052782a3d4
`doVoting` built the three gas votes unconditionally. Before the amendment, the ledger reports zero for all three while the config targets are non-zero by default, and the loop that collects validator votes is itself gated on the amendment — so the vote map held only our own target and every one of the three reported a change. The result was a `SetFee` pseudo-transaction on every flag ledger, from every node running this build, for as long as the amendment stayed disabled. The transaction carried no gas fields, since that part was gated correctly, so it proposed no change at all. Gate the three flags on the amendment, matching `doValidation`, which already had its gas votes inside the same check. Reported by xrplf-ai-reviewer on #8214.
XRPL Source Guidelines
Each folder contains a single module following the newest style:
- One class per header
- As much implementation hidden as possible
- All major interfaces are abstract
- Every class is documented
- Each module focuses on solving one problem