mirror of
https://github.com/XRPLF/rippled.git
synced 2026-09-27 07:26:51 +00:00
5ce7e4e855
Three fixes in the telemetry wiring this branch owns. An OTel collector records through the global meter provider, which only the telemetry module installs. With [telemetry] enabled=0 the collector attached to the SDK's noop provider, dropped every metric, and still logged that it had started. makeCollectorManager now takes whether telemetry is on and warns; what gets built is unchanged. telemetry_ is constructed before collectorManager_, so the value is available. The default metrics endpoint was spelled three times. Name it once as kDefaultMetricsEndpoint, beside the export-cadence defaults that already live in Telemetry.h for the same reason, and read it from the Setup member, the config parser's default and the collector. The scheme guard ran only when tls_client_cert was set, so use_tls=1 on an http endpoint validated the certificate files and then exported in the clear. It now covers every use_tls=1 node, for both signals. Two cases that pinned the old behaviour are flipped to _throws, each asserting which endpoint key the message names, and three more get https endpoints so the scheme guard is not what fires.