mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-22 06:40:53 +00:00
2f31a749a3
Five review findings. The validation_accept span started inside the "outcome is Current" branch, so validation_status could only ever read "current" and the four rejected values were unreachable. That defeated the attribute: a node whose trusted validations are all rejected emitted no span at all, so it looked the same as a quiet node. The span now starts before the outcome is checked, still for trusted validations only, so a rejected one is recorded with its real status. The rest are consistency fixes: ValidatorSite passes the parse_error constant instead of the literal, the 28 gauge callbacks that spelled the `metric` label key as a literal now use label::metric like the other two, a stray blank first line is gone from six files, and MetricsRegistry.cpp loses a duplicate Doxygen block that documented addHistogramView but sat above an unrelated constant.
XRPL Source Guidelines
Each folder contains a single module following the newest style:
- One class per header
- As much implementation hidden as possible
- All major interfaces are abstract
- Every class is documented
- Each module focuses on solving one problem