mirror of
https://github.com/XRPLF/rippled.git
synced 2026-06-03 08:46:46 +00:00
d6b101069e
Phase-3 (PR #6425) is scoped to transaction tracing only; consensus tracing belongs to phase-4 (PR #6426). The previous commit on this branch removed the namespace/attribute scaffoldingc6c019ed8bleaked into phase-3, but phase-3 still carried the consensus span construction and trace-context propagation introduced in earlier commits (61cb1faf8f,93bed03d8d). Move that out too so phase-3 creates and propagates no consensus spans of any kind. Removed: - src/xrpld/telemetry/ConsensusReceiveTracing.h (deleted; phase-4 owns it). - PeerImp.cpp: remove the std::make_shared<SpanGuard>( proposalReceiveSpan(...))/validationReceiveSpan(...) constructions in onMessage(TMProposeSet)/onMessage(TMValidation), drop the sp = std::move(span) lambda captures, and drop the #include <xrpld/telemetry/ConsensusReceiveTracing.h>. - RCLConsensus.cpp: drop the two telemetry::injectToProtobuf() blocks that injected the active trace context into TMProposeSet (in Adaptor::propose, after addSuppression) and TMValidation (in Adaptor::validate, around the broadcast call). Drop the now-unused #include of TraceContextPropagator.h and the XRPL_ENABLE_TELEMETRY-gated include of opentelemetry/context/runtime_context.h. - TraceContextPropagator.h: update file-level @see comment to drop the ConsensusReceiveTracing.h reference and to scope the "wired into the P2P message flow via PropagationHelpers.h" sentence to TMTransaction only. - PropagationHelpers.h: replace the @see ConsensusReceiveTracing.h cross-reference with @see TxTracing.h. Inert consensus metadata (TraceCategory::Consensus enum value, seg::consensus constant, isCategoryEnabled/categoryToSpanKind switch arms, the SpanGuard.h doc-comment example) is intentionally preserved on phase-3: nothing references it after this commit, but phase-4 needs it and removing it would widen the phase-3 -> phase-4 merge surface for no benefit. Verified via git grep: no remaining phase-3 references to proposalReceiveSpan, validationReceiveSpan, ConsensusReceiveTracing, consensus_span::, consensus.proposal, or consensus.validation. Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>