mirror of
https://github.com/XRPLF/rippled.git
synced 2025-12-06 17:27:55 +00:00
If the JobQueue is used during shutdown then those Jobs may access Stoppables after they have already stopped. This violates the preconditions of Stoppables and may lead to undefined behavior. The solution taken here is to reference count all Jobs in the JobQueue. At stop time all Jobs already in the JobQueue are allowed to run to completion, but no further Jobs are allowed into the JobQueue. If a Job is rejected from the JobQueue (because we are stopping), then JobQueue::addJob() returns false, so the caller can make any necessary adjustments.
167 lines
3.7 KiB
C++
167 lines
3.7 KiB
C++
//------------------------------------------------------------------------------
|
|
/*
|
|
This file is part of rippled: https://github.com/ripple/rippled
|
|
Copyright (c) 2012, 2013 Ripple Labs Inc.
|
|
|
|
Permission to use, copy, modify, and/or distribute this software for any
|
|
purpose with or without fee is hereby granted, provided that the above
|
|
copyright notice and this permission notice appear in all copies.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
//==============================================================================
|
|
|
|
#ifndef RIPPLE_CORE_COROINL_H_INCLUDED
|
|
#define RIPPLE_CORE_COROINL_H_INCLUDED
|
|
|
|
namespace ripple {
|
|
|
|
template <class F>
|
|
JobQueue::Coro::
|
|
Coro(Coro_create_t, JobQueue& jq, JobType type,
|
|
std::string const& name, F&& f)
|
|
: jq_(jq)
|
|
, type_(type)
|
|
, name_(name)
|
|
, running_(false)
|
|
, coro_(
|
|
[this, fn = std::forward<F>(f)]
|
|
(boost::coroutines::asymmetric_coroutine<void>::push_type& do_yield)
|
|
{
|
|
yield_ = &do_yield;
|
|
yield();
|
|
fn(shared_from_this());
|
|
#ifndef NDEBUG
|
|
finished_ = true;
|
|
#endif
|
|
}, boost::coroutines::attributes (1024 * 1024))
|
|
{
|
|
}
|
|
|
|
inline
|
|
JobQueue::Coro::
|
|
~Coro()
|
|
{
|
|
#ifndef NDEBUG
|
|
assert(finished_);
|
|
#endif
|
|
}
|
|
|
|
inline
|
|
void
|
|
JobQueue::Coro::
|
|
yield() const
|
|
{
|
|
{
|
|
std::lock_guard<std::mutex> lock(jq_.m_mutex);
|
|
++jq_.nSuspend_;
|
|
}
|
|
(*yield_)();
|
|
}
|
|
|
|
inline
|
|
bool
|
|
JobQueue::Coro::
|
|
post()
|
|
{
|
|
{
|
|
std::lock_guard<std::mutex> lk(mutex_run_);
|
|
running_ = true;
|
|
}
|
|
|
|
// sp keeps 'this' alive
|
|
if (jq_.addJob(type_, name_,
|
|
[this, sp = shared_from_this()](Job&)
|
|
{
|
|
resume();
|
|
}))
|
|
{
|
|
return true;
|
|
}
|
|
|
|
// The coroutine will not run. Clean up running_.
|
|
std::lock_guard<std::mutex> lk(mutex_run_);
|
|
running_ = false;
|
|
cv_.notify_all();
|
|
return false;
|
|
}
|
|
|
|
inline
|
|
void
|
|
JobQueue::Coro::
|
|
resume()
|
|
{
|
|
{
|
|
std::lock_guard<std::mutex> lk(mutex_run_);
|
|
running_ = true;
|
|
}
|
|
{
|
|
std::lock_guard<std::mutex> lock(jq_.m_mutex);
|
|
--jq_.nSuspend_;
|
|
}
|
|
auto saved = detail::getLocalValues().release();
|
|
detail::getLocalValues().reset(&lvs_);
|
|
std::lock_guard<std::mutex> lock(mutex_);
|
|
assert (coro_);
|
|
coro_();
|
|
detail::getLocalValues().release();
|
|
detail::getLocalValues().reset(saved);
|
|
std::lock_guard<std::mutex> lk(mutex_run_);
|
|
running_ = false;
|
|
cv_.notify_all();
|
|
}
|
|
|
|
inline
|
|
bool
|
|
JobQueue::Coro::
|
|
runnable() const
|
|
{
|
|
return static_cast<bool>(coro_);
|
|
}
|
|
|
|
inline
|
|
void
|
|
JobQueue::Coro::
|
|
expectEarlyExit()
|
|
{
|
|
#ifndef NDEBUG
|
|
if (! finished_)
|
|
#endif
|
|
{
|
|
// expectEarlyExit() must only ever be called from outside the
|
|
// Coro's stack. It you're inside the stack you can simply return
|
|
// and be done.
|
|
//
|
|
// That said, since we're outside the Coro's stack, we need to
|
|
// decrement the nSuspend that the Coro's call to yield caused.
|
|
std::lock_guard<std::mutex> lock(jq_.m_mutex);
|
|
--jq_.nSuspend_;
|
|
#ifndef NDEBUG
|
|
finished_ = true;
|
|
#endif
|
|
}
|
|
}
|
|
|
|
inline
|
|
void
|
|
JobQueue::Coro::
|
|
join()
|
|
{
|
|
std::unique_lock<std::mutex> lk(mutex_run_);
|
|
cv_.wait(lk,
|
|
[this]()
|
|
{
|
|
return running_ == false;
|
|
});
|
|
}
|
|
|
|
} // ripple
|
|
|
|
#endif
|