mirror of
https://github.com/XRPLF/rippled.git
synced 2026-07-30 10:30:22 +00:00
8fab4ae507
The decision rule for "slow to reach full" keyed on an absolute read-time threshold and a found-rate threshold that misclassified the very run they were written to explain: a populated-store run reading 31.8 us at 88.3% found fell through both cuts and came out as "disk-bound" rather than the cold-read case it is. Replace it with two ordered questions -- is the read cost several times a warm read, and is the write path queueing -- and demote the found rate to a splitter that only applies once reads are known to be expensive. A high found rate on its own is the normal state of a populated store, so it can never be a trigger. The rule now classifies all four reference datasets correctly, and the runbook shows the rule applied to each so the "confirm against the reference points" step agrees with the table. Also in the runbook: - name the source of the devnet incident figures at the point of use, and point forward to the caveat from the same paragraph - state the provenance of the measured columns, and split the incident figures into their own table marked as not our measurement - say plainly that the compounding-factor explanation is an unconfirmed hypothesis - correct the deferral gate: it fires at the acquisition's own job limit of 5, not at the ledgerData lane cap of 3 - note that no read-max gauge exists, so the tie-break uses max_over_time of the mean or the read histogram's p99 - split a PromQL block that put two expressions on adjacent lines, which parses as one invalid expression In the data-collection reference: - node_reads_hit counts fetches that found an object, not cache hits - nudb_bytes is cumulative payload bytes from the same accessor as node_written_bytes, not on-disk size, so their ratio is a constant 1.0 - write_load and nudb_writers_in_flight are the same atomic on NuDB; document that and what write_load means on RocksDB - correct the instrument count to 8 and the view count to 7 after nodestore_read_us and its view were added - scope the Phase 9 query examples to one node with the regex form Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>