mirror of
https://github.com/XRPLF/rippled.git
synced 2026-01-31 03:55:27 +00:00
This change continues the thread naming work from #5691 and #5758, which enables more useful lock contention profiling by ensuring threads/jobs have short, stable, human-readable names (rather than being truncated/failing due to OS limits). This changes diagnostic naming only (thread names and job/load-event labels), not behavior. Specific modifications are: * Shortens all thread/job names used with `beast::setCurrentThreadName`, so the effective Linux thread name stays within the 15-character limit. * Removes per-ledger sequence numbers from job/thread names to avoid long labels. This improves aggregation in lock contention profiling for short-lived job executions.
172 lines
4.0 KiB
C++
172 lines
4.0 KiB
C++
#include <test/jtx.h>
|
|
|
|
#include <xrpl/core/JobQueue.h>
|
|
|
|
#include <chrono>
|
|
#include <mutex>
|
|
|
|
namespace xrpl {
|
|
namespace test {
|
|
|
|
class Coroutine_test : public beast::unit_test::suite
|
|
{
|
|
public:
|
|
class gate
|
|
{
|
|
private:
|
|
std::condition_variable cv_;
|
|
std::mutex mutex_;
|
|
bool signaled_ = false;
|
|
|
|
public:
|
|
// Thread safe, blocks until signaled or period expires.
|
|
// Returns `true` if signaled.
|
|
template <class Rep, class Period>
|
|
bool
|
|
wait_for(std::chrono::duration<Rep, Period> const& rel_time)
|
|
{
|
|
std::unique_lock<std::mutex> lk(mutex_);
|
|
auto b = cv_.wait_for(lk, rel_time, [this] { return signaled_; });
|
|
signaled_ = false;
|
|
return b;
|
|
}
|
|
|
|
void
|
|
signal()
|
|
{
|
|
std::lock_guard lk(mutex_);
|
|
signaled_ = true;
|
|
cv_.notify_all();
|
|
}
|
|
};
|
|
|
|
void
|
|
correct_order()
|
|
{
|
|
using namespace std::chrono_literals;
|
|
using namespace jtx;
|
|
|
|
testcase("correct order");
|
|
|
|
Env env(*this, envconfig([](std::unique_ptr<Config> cfg) {
|
|
cfg->FORCE_MULTI_THREAD = true;
|
|
return cfg;
|
|
}));
|
|
|
|
gate g1, g2;
|
|
std::shared_ptr<JobQueue::Coro> c;
|
|
env.app().getJobQueue().postCoro(
|
|
jtCLIENT, "CoroTest", [&](auto const& cr) {
|
|
c = cr;
|
|
g1.signal();
|
|
c->yield();
|
|
g2.signal();
|
|
});
|
|
BEAST_EXPECT(g1.wait_for(5s));
|
|
c->join();
|
|
c->post();
|
|
BEAST_EXPECT(g2.wait_for(5s));
|
|
}
|
|
|
|
void
|
|
incorrect_order()
|
|
{
|
|
using namespace std::chrono_literals;
|
|
using namespace jtx;
|
|
|
|
testcase("incorrect order");
|
|
|
|
Env env(*this, envconfig([](std::unique_ptr<Config> cfg) {
|
|
cfg->FORCE_MULTI_THREAD = true;
|
|
return cfg;
|
|
}));
|
|
|
|
gate g;
|
|
env.app().getJobQueue().postCoro(
|
|
jtCLIENT, "CoroTest", [&](auto const& c) {
|
|
c->post();
|
|
c->yield();
|
|
g.signal();
|
|
});
|
|
BEAST_EXPECT(g.wait_for(5s));
|
|
}
|
|
|
|
void
|
|
thread_specific_storage()
|
|
{
|
|
using namespace std::chrono_literals;
|
|
using namespace jtx;
|
|
|
|
testcase("thread specific storage");
|
|
Env env(*this);
|
|
|
|
auto& jq = env.app().getJobQueue();
|
|
|
|
static int const N = 4;
|
|
std::array<std::shared_ptr<JobQueue::Coro>, N> a;
|
|
|
|
LocalValue<int> lv(-1);
|
|
BEAST_EXPECT(*lv == -1);
|
|
|
|
gate g;
|
|
jq.addJob(jtCLIENT, "LocalValTest", [&]() {
|
|
this->BEAST_EXPECT(*lv == -1);
|
|
*lv = -2;
|
|
this->BEAST_EXPECT(*lv == -2);
|
|
g.signal();
|
|
});
|
|
BEAST_EXPECT(g.wait_for(5s));
|
|
BEAST_EXPECT(*lv == -1);
|
|
|
|
for (int i = 0; i < N; ++i)
|
|
{
|
|
jq.postCoro(jtCLIENT, "CoroTest", [&, id = i](auto const& c) {
|
|
a[id] = c;
|
|
g.signal();
|
|
c->yield();
|
|
|
|
this->BEAST_EXPECT(*lv == -1);
|
|
*lv = id;
|
|
this->BEAST_EXPECT(*lv == id);
|
|
g.signal();
|
|
c->yield();
|
|
|
|
this->BEAST_EXPECT(*lv == id);
|
|
});
|
|
BEAST_EXPECT(g.wait_for(5s));
|
|
a[i]->join();
|
|
}
|
|
for (auto const& c : a)
|
|
{
|
|
c->post();
|
|
BEAST_EXPECT(g.wait_for(5s));
|
|
c->join();
|
|
}
|
|
for (auto const& c : a)
|
|
{
|
|
c->post();
|
|
c->join();
|
|
}
|
|
|
|
jq.addJob(jtCLIENT, "LocalValTest", [&]() {
|
|
this->BEAST_EXPECT(*lv == -2);
|
|
g.signal();
|
|
});
|
|
BEAST_EXPECT(g.wait_for(5s));
|
|
BEAST_EXPECT(*lv == -1);
|
|
}
|
|
|
|
void
|
|
run() override
|
|
{
|
|
correct_order();
|
|
incorrect_order();
|
|
thread_specific_storage();
|
|
}
|
|
};
|
|
|
|
BEAST_DEFINE_TESTSUITE(Coroutine, core, xrpl);
|
|
|
|
} // namespace test
|
|
} // namespace xrpl
|